diff mbox series

[v3,09/21] arm: dts: Use consistent name "CLK_ETHERNET" for the Ethernet clock binding

Message ID 1579954983-11329-10-git-send-email-amittomer25@gmail.com
State New
Headers show
Series Actions S700 SoC support | expand

Commit Message

Amit Tomer Jan. 25, 2020, 12:22 p.m. UTC
Right now, Clock bindings for ethernet uses different names(even in Linux)
CLK_ETH_MAC for S900 and CLK_ETHERNET for S700, It causes compilation problem
when using them for common clock driver.

Let's use same name CLK_ETHERNET for both S700 and S900.

Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com>
---
Changes since v2:
	* Newly added patch, not there in v2/v1.
---
 include/dt-bindings/clock/actions,s900-cmu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Amit Tomer March 3, 2020, 8:28 a.m. UTC | #1
Hi,

> So either you send this patch to the kernel first, or, probably better, you drop this change here, and unify the name at the point where it's used (#ifndef CLK_ETHERNET ....)

But this is something mentioned in cover letter:

"Patch(9/21) uses same name for ethernet clock binding and if it's ok,
would like to send it to LKML
as well."

anyways as suggested by Mani to drop Ethernet related patches for now,
this patch is not necessary in that case.
Meanwhile, would send it to LKML first for a review.

Thanks
-Amit
diff mbox series

Patch

diff --git a/include/dt-bindings/clock/actions,s900-cmu.h b/include/dt-bindings/clock/actions,s900-cmu.h
index 7c12515..2247f1c 100644
--- a/include/dt-bindings/clock/actions,s900-cmu.h
+++ b/include/dt-bindings/clock/actions,s900-cmu.h
@@ -121,7 +121,7 @@ 
 #define CLK_DDR1			97
 #define CLK_DMM				98
 
-#define CLK_ETH_MAC			99
+#define CLK_ETHERNET			99
 #define CLK_RMII_REF			100
 
 #define CLK_NR_CLKS			(CLK_RMII_REF + 1)