diff mbox series

[v2,5/9] lib: Makefile: build crc7.c when CONFIG_MMC_SPI

Message ID	20200117124616.24695-6-pragnesh.patel@sifive.com
State	New
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: pragnesh.patel at sifive.com (Pragnesh Patel) Date: Fri, 17 Jan 2020 18:16:11 +0530 Subject: [PATCH v2 5/9] lib: Makefile: build crc7.c when CONFIG_MMC_SPI In-Reply-To: <20200117124616.24695-1-pragnesh.patel@sifive.com> References: <20200117124616.24695-1-pragnesh.patel@sifive.com> Message-ID: <20200117124616.24695-6-pragnesh.patel@sifive.com>
Series	RISC-V SiFive FU540 support SPL \| expand [v2,0/9] RISC-V SiFive FU540 support SPL [v2,1/9] misc: add driver for the Sifive otp controller [v2,2/9] Sifive: FU540: Add place-holder for FU540 clk [v2,3/9] Sifive: FU540: Add header files for SoC [v2,4/9] riscv: Add _image_binary_end for SPL [v2,5/9] lib: Makefile: build crc7.c when CONFIG_MMC_SPI [v2,6/9] riscv: sifive: dts: fu540: Add board -u-boot.dtsi files [v2,7/9] riscv: sifive: fu540: Add U-boot SPL header files [v2,8/9] riscv: sifive: fu540: add SPL configuration [v2,9/9] doc: update FU540 RISC-V documentation

Commit Message

Pragnesh Patel Jan. 17, 2020, 12:46 p.m. UTC

When build U-boot SPL, meet an issue of undefined reference to
'crc7' for drivers/mmc/mmc_spi.c, so let's compile crc7.c when
CONFIG_MMC_SPI selected.

Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
---
 lib/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Anup Patel Jan. 20, 2020, 4:59 a.m. UTC | #1

On Fri, Jan 17, 2020 at 6:18 PM Pragnesh Patel
<pragnesh.patel at sifive.com> wrote:
>
> When build U-boot SPL, meet an issue of undefined reference to
> 'crc7' for drivers/mmc/mmc_spi.c, so let's compile crc7.c when
> CONFIG_MMC_SPI selected.
>
> Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
> ---
>  lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 6b7b9ce85c..8e3a071786 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -77,6 +77,7 @@ endif
>
>  ifdef CONFIG_SPL_BUILD
>  obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16.o
> +obj-$(CONFIG_MMC_SPI) += crc7.o
>  obj-$(CONFIG_$(SPL_TPL_)HASH_SUPPORT) += crc16.o
>  obj-y += net_utils.o
>  endif
> --
> 2.17.1
>

LGTM.

Reviewed-by: Anup Patel <anup.patel at wdc.com>

Regards,
Anup

diff mbox series

Patch

diff --git a/lib/Makefile b/lib/Makefile
index 6b7b9ce85c..8e3a071786 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -77,6 +77,7 @@  endif
 
 ifdef CONFIG_SPL_BUILD
 obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16.o
+obj-$(CONFIG_MMC_SPI) += crc7.o
 obj-$(CONFIG_$(SPL_TPL_)HASH_SUPPORT) += crc16.o
 obj-y += net_utils.o
 endif