diff mbox series

[v2,11/21] dts: mtmips: remove all unusable nodes and properties from mt7628s.dtsi

Message ID 1579247158-32706-1-git-send-email-weijie.gao@mediatek.com
State New
Headers show
Series None | expand

Commit Message

Weijie Gao Jan. 17, 2020, 7:45 a.m. UTC
This patch removes all unused and unusable nodes and properties from
mt7628s.dtsi.

Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
---
Changes since v1: splitted from another patch
---
 arch/mips/dts/mt7628a.dtsi | 68 --------------------------------------
 1 file changed, 68 deletions(-)

Comments

Stefan Roese Jan. 17, 2020, 2:42 p.m. UTC | #1
On 17.01.20 08:45, Weijie Gao wrote:
> This patch removes all unused and unusable nodes and properties from
> mt7628s.dtsi.
> 
> Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
> ---
> Changes since v1: splitted from another patch

Please don't remove the unused parts. As mentioned before, we try to
stay as close to the official DT files from the Linux tree as possible.
Goal is to sync with Linux at some time. This is already done on other
architectures / boards.

Thanks,
Stefan

> ---
>   arch/mips/dts/mt7628a.dtsi | 68 --------------------------------------
>   1 file changed, 68 deletions(-)
> 
> diff --git a/arch/mips/dts/mt7628a.dtsi b/arch/mips/dts/mt7628a.dtsi
> index cdc643fe37..3d7b839e6d 100644
> --- a/arch/mips/dts/mt7628a.dtsi
> +++ b/arch/mips/dts/mt7628a.dtsi
> @@ -7,24 +7,6 @@
>   	#size-cells = <1>;
>   	compatible = "ralink,mt7628a-soc";
>   
> -	cpus {
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
> -		cpu at 0 {
> -			compatible = "mti,mips24KEc";
> -			device_type = "cpu";
> -			reg = <0>;
> -		};
> -	};
> -
> -	cpuintc: interrupt-controller {
> -		#address-cells = <0>;
> -		#interrupt-cells = <1>;
> -		interrupt-controller;
> -		compatible = "mti,cpu-interrupt-controller";
> -	};
> -
>   	clk48m: clk48m at 0 {
>   		compatible = "fixed-clock";
>   
> @@ -41,11 +23,6 @@
>   		#address-cells = <1>;
>   		#size-cells = <1>;
>   
> -		sysc: system-controller at 0 {
> -			compatible = "ralink,mt7620a-sysc", "syscon";
> -			reg = <0x0 0x100>;
> -		};
> -
>   		resetctl-reboot {
>   			compatible = "resetctl-reboot";
>   
> @@ -223,32 +200,6 @@
>   
>   			resets = <&rstctrl MT7628_TIMER_RST>;
>   			reset-names = "wdt";
> -
> -			interrupt-parent = <&intc>;
> -			interrupts = <24>;
> -		};
> -
> -		intc: interrupt-controller at 200 {
> -			compatible = "ralink,rt2880-intc";
> -			reg = <0x200 0x100>;
> -
> -			interrupt-controller;
> -			#interrupt-cells = <1>;
> -
> -			resets = <&rstctrl MT7628_INT_RST>;
> -			reset-names = "intc";
> -
> -			interrupt-parent = <&cpuintc>;
> -			interrupts = <2>;
> -
> -			ralink,intc-registers = <0x9c 0xa0
> -						 0x6c 0xa4
> -						 0x80 0x78>;
> -		};
> -
> -		memory-controller at 300 {
> -			compatible = "ralink,mt7620a-memc";
> -			reg = <0x300 0x100>;
>   		};
>   
>   		gpio at 600 {
> @@ -261,9 +212,6 @@
>   			resets = <&rstctrl MT7628_PIO_RST>;
>   			reset-names = "pio";
>   
> -			interrupt-parent = <&intc>;
> -			interrupts = <6>;
> -
>   			gpio0: bank at 0 {
>   				reg = <0>;
>   				compatible = "mtk,mt7621-gpio-bank";
> @@ -311,9 +259,6 @@
>   			resets = <&rstctrl MT7628_UART0_RST>;
>   			reset-names = "uart0";
>   
> -			interrupt-parent = <&intc>;
> -			interrupts = <20>;
> -
>   			reg-shift = <2>;
>   		};
>   
> @@ -329,9 +274,6 @@
>   			resets = <&rstctrl MT7628_UART1_RST>;
>   			reset-names = "uart1";
>   
> -			interrupt-parent = <&intc>;
> -			interrupts = <21>;
> -
>   			reg-shift = <2>;
>   		};
>   
> @@ -347,9 +289,6 @@
>   			resets = <&rstctrl MT7628_UART2_RST>;
>   			reset-names = "uart2";
>   
> -			interrupt-parent = <&intc>;
> -			interrupts = <22>;
> -
>   			reg-shift = <2>;
>   		};
>   	};
> @@ -361,8 +300,6 @@
>   
>   		resets = <&rstctrl MT7628_EPHY_RST>;
>   		reset-names = "ephy";
> -
> -		syscon = <&sysc>;
>   	};
>   
>   	usb_phy: usb-phy at 10120000 {
> @@ -371,8 +308,6 @@
>   
>   		#phy-cells = <0>;
>   
> -		ralink,sysctl = <&sysc>;
> -
>   		resets = <&rstctrl MT7628_UPHY_RST>;
>   		reset-names = "phy";
>   
> @@ -386,9 +321,6 @@
>   
>   		phys = <&usb_phy>;
>   		phy-names = "usb";
> -
> -		interrupt-parent = <&intc>;
> -		interrupts = <18>;
>   	};
>   
>   	mmc: mmc at 10130000 {
> 

Viele Grüße,
Stefan
Weijie Gao Jan. 19, 2020, 2:14 a.m. UTC | #2
On Fri, 2020-01-17 at 15:42 +0100, Stefan Roese wrote:
> On 17.01.20 08:45, Weijie Gao wrote:
> > This patch removes all unused and unusable nodes and properties from
> > mt7628s.dtsi.
> > 
> > Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
> > ---
> > Changes since v1: splitted from another patch
> 
> Please don't remove the unused parts. As mentioned before, we try to
> stay as close to the official DT files from the Linux tree as possible.
> Goal is to sync with Linux at some time. This is already done on other
> architectures / boards.

OK. I'll drop this one.

> 
> Thanks,
> Stefan
> 
> > ---
> >   arch/mips/dts/mt7628a.dtsi | 68 --------------------------------------
> >   1 file changed, 68 deletions(-)
> > 
> > diff --git a/arch/mips/dts/mt7628a.dtsi b/arch/mips/dts/mt7628a.dtsi
> > index cdc643fe37..3d7b839e6d 100644
> > --- a/arch/mips/dts/mt7628a.dtsi
> > +++ b/arch/mips/dts/mt7628a.dtsi
> > @@ -7,24 +7,6 @@
> >   	#size-cells = <1>;
> >   	compatible = "ralink,mt7628a-soc";
> >   
> > -	cpus {
> > -		#address-cells = <1>;
> > -		#size-cells = <0>;
> > -
> > -		cpu at 0 {
> > -			compatible = "mti,mips24KEc";
> > -			device_type = "cpu";
> > -			reg = <0>;
> > -		};
> > -	};
> > -
> > -	cpuintc: interrupt-controller {
> > -		#address-cells = <0>;
> > -		#interrupt-cells = <1>;
> > -		interrupt-controller;
> > -		compatible = "mti,cpu-interrupt-controller";
> > -	};
> > -
> >   	clk48m: clk48m at 0 {
> >   		compatible = "fixed-clock";
> >   
> > @@ -41,11 +23,6 @@
> >   		#address-cells = <1>;
> >   		#size-cells = <1>;
> >   
> > -		sysc: system-controller at 0 {
> > -			compatible = "ralink,mt7620a-sysc", "syscon";
> > -			reg = <0x0 0x100>;
> > -		};
> > -
> >   		resetctl-reboot {
> >   			compatible = "resetctl-reboot";
> >   
> > @@ -223,32 +200,6 @@
> >   
> >   			resets = <&rstctrl MT7628_TIMER_RST>;
> >   			reset-names = "wdt";
> > -
> > -			interrupt-parent = <&intc>;
> > -			interrupts = <24>;
> > -		};
> > -
> > -		intc: interrupt-controller at 200 {
> > -			compatible = "ralink,rt2880-intc";
> > -			reg = <0x200 0x100>;
> > -
> > -			interrupt-controller;
> > -			#interrupt-cells = <1>;
> > -
> > -			resets = <&rstctrl MT7628_INT_RST>;
> > -			reset-names = "intc";
> > -
> > -			interrupt-parent = <&cpuintc>;
> > -			interrupts = <2>;
> > -
> > -			ralink,intc-registers = <0x9c 0xa0
> > -						 0x6c 0xa4
> > -						 0x80 0x78>;
> > -		};
> > -
> > -		memory-controller at 300 {
> > -			compatible = "ralink,mt7620a-memc";
> > -			reg = <0x300 0x100>;
> >   		};
> >   
> >   		gpio at 600 {
> > @@ -261,9 +212,6 @@
> >   			resets = <&rstctrl MT7628_PIO_RST>;
> >   			reset-names = "pio";
> >   
> > -			interrupt-parent = <&intc>;
> > -			interrupts = <6>;
> > -
> >   			gpio0: bank at 0 {
> >   				reg = <0>;
> >   				compatible = "mtk,mt7621-gpio-bank";
> > @@ -311,9 +259,6 @@
> >   			resets = <&rstctrl MT7628_UART0_RST>;
> >   			reset-names = "uart0";
> >   
> > -			interrupt-parent = <&intc>;
> > -			interrupts = <20>;
> > -
> >   			reg-shift = <2>;
> >   		};
> >   
> > @@ -329,9 +274,6 @@
> >   			resets = <&rstctrl MT7628_UART1_RST>;
> >   			reset-names = "uart1";
> >   
> > -			interrupt-parent = <&intc>;
> > -			interrupts = <21>;
> > -
> >   			reg-shift = <2>;
> >   		};
> >   
> > @@ -347,9 +289,6 @@
> >   			resets = <&rstctrl MT7628_UART2_RST>;
> >   			reset-names = "uart2";
> >   
> > -			interrupt-parent = <&intc>;
> > -			interrupts = <22>;
> > -
> >   			reg-shift = <2>;
> >   		};
> >   	};
> > @@ -361,8 +300,6 @@
> >   
> >   		resets = <&rstctrl MT7628_EPHY_RST>;
> >   		reset-names = "ephy";
> > -
> > -		syscon = <&sysc>;
> >   	};
> >   
> >   	usb_phy: usb-phy at 10120000 {
> > @@ -371,8 +308,6 @@
> >   
> >   		#phy-cells = <0>;
> >   
> > -		ralink,sysctl = <&sysc>;
> > -
> >   		resets = <&rstctrl MT7628_UPHY_RST>;
> >   		reset-names = "phy";
> >   
> > @@ -386,9 +321,6 @@
> >   
> >   		phys = <&usb_phy>;
> >   		phy-names = "usb";
> > -
> > -		interrupt-parent = <&intc>;
> > -		interrupts = <18>;
> >   	};
> >   
> >   	mmc: mmc at 10130000 {
> > 
> 
> Viele Grüße,
> Stefan
>
diff mbox series

Patch

diff --git a/arch/mips/dts/mt7628a.dtsi b/arch/mips/dts/mt7628a.dtsi
index cdc643fe37..3d7b839e6d 100644
--- a/arch/mips/dts/mt7628a.dtsi
+++ b/arch/mips/dts/mt7628a.dtsi
@@ -7,24 +7,6 @@ 
 	#size-cells = <1>;
 	compatible = "ralink,mt7628a-soc";
 
-	cpus {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		cpu at 0 {
-			compatible = "mti,mips24KEc";
-			device_type = "cpu";
-			reg = <0>;
-		};
-	};
-
-	cpuintc: interrupt-controller {
-		#address-cells = <0>;
-		#interrupt-cells = <1>;
-		interrupt-controller;
-		compatible = "mti,cpu-interrupt-controller";
-	};
-
 	clk48m: clk48m at 0 {
 		compatible = "fixed-clock";
 
@@ -41,11 +23,6 @@ 
 		#address-cells = <1>;
 		#size-cells = <1>;
 
-		sysc: system-controller at 0 {
-			compatible = "ralink,mt7620a-sysc", "syscon";
-			reg = <0x0 0x100>;
-		};
-
 		resetctl-reboot {
 			compatible = "resetctl-reboot";
 
@@ -223,32 +200,6 @@ 
 
 			resets = <&rstctrl MT7628_TIMER_RST>;
 			reset-names = "wdt";
-
-			interrupt-parent = <&intc>;
-			interrupts = <24>;
-		};
-
-		intc: interrupt-controller at 200 {
-			compatible = "ralink,rt2880-intc";
-			reg = <0x200 0x100>;
-
-			interrupt-controller;
-			#interrupt-cells = <1>;
-
-			resets = <&rstctrl MT7628_INT_RST>;
-			reset-names = "intc";
-
-			interrupt-parent = <&cpuintc>;
-			interrupts = <2>;
-
-			ralink,intc-registers = <0x9c 0xa0
-						 0x6c 0xa4
-						 0x80 0x78>;
-		};
-
-		memory-controller at 300 {
-			compatible = "ralink,mt7620a-memc";
-			reg = <0x300 0x100>;
 		};
 
 		gpio at 600 {
@@ -261,9 +212,6 @@ 
 			resets = <&rstctrl MT7628_PIO_RST>;
 			reset-names = "pio";
 
-			interrupt-parent = <&intc>;
-			interrupts = <6>;
-
 			gpio0: bank at 0 {
 				reg = <0>;
 				compatible = "mtk,mt7621-gpio-bank";
@@ -311,9 +259,6 @@ 
 			resets = <&rstctrl MT7628_UART0_RST>;
 			reset-names = "uart0";
 
-			interrupt-parent = <&intc>;
-			interrupts = <20>;
-
 			reg-shift = <2>;
 		};
 
@@ -329,9 +274,6 @@ 
 			resets = <&rstctrl MT7628_UART1_RST>;
 			reset-names = "uart1";
 
-			interrupt-parent = <&intc>;
-			interrupts = <21>;
-
 			reg-shift = <2>;
 		};
 
@@ -347,9 +289,6 @@ 
 			resets = <&rstctrl MT7628_UART2_RST>;
 			reset-names = "uart2";
 
-			interrupt-parent = <&intc>;
-			interrupts = <22>;
-
 			reg-shift = <2>;
 		};
 	};
@@ -361,8 +300,6 @@ 
 
 		resets = <&rstctrl MT7628_EPHY_RST>;
 		reset-names = "ephy";
-
-		syscon = <&sysc>;
 	};
 
 	usb_phy: usb-phy at 10120000 {
@@ -371,8 +308,6 @@ 
 
 		#phy-cells = <0>;
 
-		ralink,sysctl = <&sysc>;
-
 		resets = <&rstctrl MT7628_UPHY_RST>;
 		reset-names = "phy";
 
@@ -386,9 +321,6 @@ 
 
 		phys = <&usb_phy>;
 		phy-names = "usb";
-
-		interrupt-parent = <&intc>;
-		interrupts = <18>;
 	};
 
 	mmc: mmc at 10130000 {