diff mbox series

test/cmd_ut.c: fix cmd_ut_category

Message ID 1578587642-2109-1-git-send-email-philippe.reynes@softathome.com
State Accepted
Commit 3f05f087c37ec6b408dfd3b0a864c59749b5b8e1
Headers show
Series test/cmd_ut.c: fix cmd_ut_category | expand

Commit Message

Philippe REYNES Jan. 9, 2020, 4:34 p.m. UTC
In the function cmd_ut_category, the prefix is used with
the function strncmp to know if the prefix should be
removed from the test name, even if the prefix is NULL.

To avoid this issue, we consider that a prefix NULL
mean no prefix. So we only try to remove the prefix
from the test_name if the prefix is not NULL, then
we avoid to call the function strncmp with a NULL
prefix.

Reported-by: Coverity CID 281110
Fixes: 4ad4edfe ("cmd_ut: add a parameter prefix to the function cmd_ut_category")
Signed-off-by: Philippe Reynes <philippe.reynes at softathome.com>
---
 test/cmd_ut.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Jan. 10, 2020, 9:51 p.m. UTC | #1
On Thu, Jan 09, 2020 at 05:34:02PM +0100, Philippe Reynes wrote:

> In the function cmd_ut_category, the prefix is used with
> the function strncmp to know if the prefix should be
> removed from the test name, even if the prefix is NULL.
> 
> To avoid this issue, we consider that a prefix NULL
> mean no prefix. So we only try to remove the prefix
> from the test_name if the prefix is not NULL, then
> we avoid to call the function strncmp with a NULL
> prefix.
> 
> Reported-by: Coverity CID 281110
> Fixes: 4ad4edfe ("cmd_ut: add a parameter prefix to the function cmd_ut_category")
> Signed-off-by: Philippe Reynes <philippe.reynes at softathome.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/test/cmd_ut.c b/test/cmd_ut.c
index 400719e..a3a9d49 100644
--- a/test/cmd_ut.c
+++ b/test/cmd_ut.c
@@ -26,7 +26,7 @@  int cmd_ut_category(const char *name, const char *prefix,
 		const char *test_name = test->name;
 
 		/* Remove the prefix */
-		if (!strncmp(test_name, prefix, prefix_len))
+		if (prefix && !strncmp(test_name, prefix, prefix_len))
 			test_name += prefix_len;
 
 		if (argc > 1 && strcmp(argv[1], test_name))