diff mbox series

U-Boot: wandboard ethernet problem with newest mainline

Message ID f55c37d9-b551-2506-7f49-080872680a01@denx.de
State New
Headers show
Series U-Boot: wandboard ethernet problem with newest mainline | expand

Commit Message

Heiko Schocher Jan. 8, 2020, 11:45 a.m. UTC
Hello Fabio,

Am 08.01.2020 um 11:11 schrieb Heiko Schocher:
> Hello Stefano, Fabio,
> 
> Am 08.01.2020 um 10:54 schrieb Stefano Babic:
>> Hi Fabio, Heiko,
>>
>> On 08/01/20 10:31, Fabio Estevam wrote:
>>> Hi Heiko,
>>>
>>> On Wed, Jan 8, 2020 at 2:41 AM Heiko Schocher <hs at denx.de> wrote:
>>>>
>>>> Hi Fabio!
>>>>
>>>> happy new year! Hope you are fine?
>>>>
>>>> I just builded the newest mainline U-Boot code for the wandboard, and
>>>> I get:
>>>>
>>>> U-Boot SPL 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100)
>>>> Trying to boot from MMC1
>>>>
>>>>
>>>> U-Boot 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100)
>>>>
>>>> CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
>>>> Reset cause: WDOG
>>>> DRAM:  1 GiB
>>>> PMIC:  pmic_get() ret -19
>>>
>>> I have already fixed this PMIC issue. Please try this series:
>>> https://lists.denx.de/pipermail/u-boot/2019-December/393500.html
>>>
>>> I thought it would reach 2020.01, but apparently it did not.
>>>
>>
>> Indeed, I am sure I have already worked and merged the series, but I
>> cannot find them, no idea why. I can just apply them now and push on
>> -master :-(
> 
> With this patch I see the same issue:
> 
> U-Boot SPL 2020.01-tbot-00273-g877a689 (Jan 08 2020 - 11:05:27 +0100)
> Trying to boot from MMC1
> 
> 
> U-Boot 2020.01-tbot-00273-g877a689 (Jan 08 2020 - 11:05:27 +0100)
> 
> CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
> Reset cause: WDOG
> DRAM:  1 GiB
> PMIC:  pmic_get() ret -19
> MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0
> Loading Environment from MMC... *** Warning - bad CRC, using default environment
> 
> No panel detected: default to HDMI
> Display: HDMI (1024x768)
> In:    serial
> Out:   serial
> Err:   serial
> Model: Wandboard i.MX6 Dual Lite Board rev B1
> Board: Wandboard rev B1
> Net:   Could not get PHY for FEC0: addr 1
> No ethernet found.
> 
> Hit any key to stop autoboot:  0
> =>
> 
> I try to dig into it ...

Hmm... current try (remove all other dts from image):


and with your patch applied, I see on the console:

resetting ...

U-Boot SPL 2020.01-tbot-00275-gae9089a (Jan 08 2020 - 11:53:10 +0100)
Trying to boot from MMC1


U-Boot 2020.01-tbot-00275-gae9089a (Jan 08 2020 - 11:53:10 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  PMIC:  PFUZE100 ID=0x10
MMC:   [    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 4.20.3-jumpnow (oe-user at oe-host) (gcc version 8.2.0 (GCC)) #1 SMP Fri 
Jan 18 17:29:07 UTC 2019
[    0.000000] CPU: ARMv7 Processor [412fc09a] revision 10 (ARMv7), cr=10c5387d
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache

So, PMIC gets now detected, but after "MMC" no output from console ...
but it seems, U-Boot boots into linux!


Hmm... looking into board/wandboard/wandboard.c

#ifdef CONFIG_SPL_LOAD_FIT
int board_fit_config_name_match(const char *name)
{
         if (is_mx6dq()) {
                 if (!strcmp(name, "imx6q-wandboard-revb1"))
                         return 0;
         } else if (is_mx6dqp()) {
                 if (!strcmp(name, "imx6qp-wandboard-revd1"))
                         return 0;
         } else if (is_mx6dl() || is_mx6solo()) {
                 if (!strcmp(name, "imx6dl-wandboard-revb1"))
                         return 0;
         }

         return -EINVAL;
}
#endif

On my board is_mx6dl() is true! but it is a revision D1 ... ?
It has definitely a pmic at 0x08

May I make something obvious wrong?

Is the content of board/wandboard/README correct?

Thanks in advance!

bye,
Heiko

Comments

Fabio Estevam Jan. 8, 2020, 12:06 p.m. UTC | #1
Hi Heiko,

On Wed, Jan 8, 2020 at 8:45 AM Heiko Schocher <hs at denx.de> wrote:

> On my board is_mx6dl() is true! but it is a revision D1 ... ?
> It has definitely a pmic at 0x08

I think we need to import the imx6dl-wandboard-d1.dts from kernel to
U-Boot and fix the board_fit_config_name_match() logic to take the
imx6dl-wandboard-d1 into account.

We will need to use is_revd1() inside board_fit_config_name_match() to
fix the detection logic.

Could you try that?

Thanks
Fabio Estevam Jan. 8, 2020, 9:11 p.m. UTC | #2
Hi Heiko,

On Wed, Jan 8, 2020 at 8:45 AM Heiko Schocher <hs at denx.de> wrote:

> diff --git a/configs/wandboard_defconfig b/configs/wandboard_defconfig
> index ca564c5..62b013c 100644
> --- a/configs/wandboard_defconfig
> +++ b/configs/wandboard_defconfig
> @@ -42,8 +42,8 @@ CONFIG_CMD_BMP=y
>   CONFIG_CMD_CACHE=y
>   CONFIG_CMD_EXT4_WRITE=y
>   CONFIG_OF_CONTROL=y
> -CONFIG_DEFAULT_DEVICE_TREE="imx6dl-wandboard-revb1"
> -CONFIG_OF_LIST="imx6q-wandboard-revb1 imx6qp-wandboard-revd1 imx6dl-wandboard-revb1"
> +CONFIG_DEFAULT_DEVICE_TREE="imx6qp-wandboard-revd1"
> +CONFIG_OF_LIST="imx6qp-wandboard-revd1"

Here you mark only the imx6qp board, but yours is a imx6dl, so that's
why the U-Boot console did not show up :-)
diff mbox series

Patch

diff --git a/configs/wandboard_defconfig b/configs/wandboard_defconfig
index ca564c5..62b013c 100644
--- a/configs/wandboard_defconfig
+++ b/configs/wandboard_defconfig
@@ -42,8 +42,8 @@  CONFIG_CMD_BMP=y
  CONFIG_CMD_CACHE=y
  CONFIG_CMD_EXT4_WRITE=y
  CONFIG_OF_CONTROL=y
-CONFIG_DEFAULT_DEVICE_TREE="imx6dl-wandboard-revb1"
-CONFIG_OF_LIST="imx6q-wandboard-revb1 imx6qp-wandboard-revd1 imx6dl-wandboard-revb1"
+CONFIG_DEFAULT_DEVICE_TREE="imx6qp-wandboard-revd1"
+CONFIG_OF_LIST="imx6qp-wandboard-revd1"
  CONFIG_MULTI_DTB_FIT=y
  CONFIG_ENV_IS_IN_MMC=y
  CONFIG_SYS_RELOC_GD_ENV_ADDR=y