| Message ID | 20200108093848.15161-1-kever.yang@rock-chips.com |
|---|---|
| State | Accepted |
| Commit | a7eb9ae349a3b7d0c44c2afa073e5df14d2a18f6 |
| Headers | show |
| Series | rockchip: rk3308: add alias for emmc/sdmmc | expand |
On Wed, Jan 8, 2020 at 3:09 PM Kever Yang <kever.yang at rock-chips.com> wrote: > > Add alias for mmc/sdmmc so that we can have a fix mmc number for emmc. > > Signed-off-by: Kever Yang <kever.yang at rock-chips.com> > --- > > arch/arm/dts/rk3308-u-boot.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/dts/rk3308-u-boot.dtsi b/arch/arm/dts/rk3308-u-boot.dtsi > index f5a595337e..4bfad31fba 100644 > --- a/arch/arm/dts/rk3308-u-boot.dtsi > +++ b/arch/arm/dts/rk3308-u-boot.dtsi > @@ -3,6 +3,13 @@ > *(C) Copyright 2019 Rockchip Electronics Co., Ltd > */ > > +/ { > + aliases { > + mmc0 = &emmc; > + mmc1 = &sdmmc; > + }; Look like other rk* have similar issue, better to move this alias to rockchip-u-boot.dtsi
On 2020/1/8 下午5:43, Jagan Teki wrote: > On Wed, Jan 8, 2020 at 3:09 PM Kever Yang <kever.yang at rock-chips.com> wrote: >> Add alias for mmc/sdmmc so that we can have a fix mmc number for emmc. >> >> Signed-off-by: Kever Yang <kever.yang at rock-chips.com> >> --- >> >> arch/arm/dts/rk3308-u-boot.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/dts/rk3308-u-boot.dtsi b/arch/arm/dts/rk3308-u-boot.dtsi >> index f5a595337e..4bfad31fba 100644 >> --- a/arch/arm/dts/rk3308-u-boot.dtsi >> +++ b/arch/arm/dts/rk3308-u-boot.dtsi >> @@ -3,6 +3,13 @@ >> *(C) Copyright 2019 Rockchip Electronics Co., Ltd >> */ >> >> +/ { >> + aliases { >> + mmc0 = &emmc; >> + mmc1 = &sdmmc; >> + }; > Look like other rk* have similar issue, better to move this alias to > rockchip-u-boot.dtsi Yes, all other SoCs have add this alias. I can't just add this to rockchp-u-boot.dtsi because there might be name difference, eg. rk3399's emmc controller is sdhci. Thanks, - Kever >
On Thu, Jan 9, 2020 at 2:25 PM Kever Yang <kever.yang at rock-chips.com> wrote: > > > On 2020/1/8 下午5:43, Jagan Teki wrote: > > On Wed, Jan 8, 2020 at 3:09 PM Kever Yang <kever.yang at rock-chips.com> wrote: > >> Add alias for mmc/sdmmc so that we can have a fix mmc number for emmc. > >> > >> Signed-off-by: Kever Yang <kever.yang at rock-chips.com> > >> --- > >> > >> arch/arm/dts/rk3308-u-boot.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm/dts/rk3308-u-boot.dtsi b/arch/arm/dts/rk3308-u-boot.dtsi > >> index f5a595337e..4bfad31fba 100644 > >> --- a/arch/arm/dts/rk3308-u-boot.dtsi > >> +++ b/arch/arm/dts/rk3308-u-boot.dtsi > >> @@ -3,6 +3,13 @@ > >> *(C) Copyright 2019 Rockchip Electronics Co., Ltd > >> */ > >> > >> +/ { > >> + aliases { > >> + mmc0 = &emmc; > >> + mmc1 = &sdmmc; > >> + }; > > Look like other rk* have similar issue, better to move this alias to > > rockchip-u-boot.dtsi > > Yes, all other SoCs have add this alias. > > I can't just add this to rockchp-u-boot.dtsi because there might be name > difference, eg. rk3399's > > emmc controller is sdhci. Yeah, seen it yesterday. Reviewed-by: Jagan Teki <jagan at amarulasolutions.com>
diff --git a/arch/arm/dts/rk3308-u-boot.dtsi b/arch/arm/dts/rk3308-u-boot.dtsi index f5a595337e..4bfad31fba 100644 --- a/arch/arm/dts/rk3308-u-boot.dtsi +++ b/arch/arm/dts/rk3308-u-boot.dtsi @@ -3,6 +3,13 @@ *(C) Copyright 2019 Rockchip Electronics Co., Ltd */ +/ { + aliases { + mmc0 = &emmc; + mmc1 = &sdmmc; + }; +}; + &cru { u-boot,dm-pre-reloc; };
Add alias for mmc/sdmmc so that we can have a fix mmc number for emmc. Signed-off-by: Kever Yang <kever.yang at rock-chips.com> --- arch/arm/dts/rk3308-u-boot.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)