| Message ID | 1588152419-18952-1-git-send-email-madalin.bucur@oss.nxp.com |
|---|---|
| State | Accepted |
| Commit | 3374264df97b23d6023be27f1301421be2e42c13 |
| Headers | show |
| Series | drivers: net: qe: deselect QE when DM_ETH is enabled | expand |
>-----Original Message----- >From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Madalin Bucur >Sent: Wednesday, April 29, 2020 2:57 PM >To: Priyanka Jain <priyanka.jain at nxp.com>; u-boot at lists.denx.de >Cc: Madalin Bucur (OSS) <madalin.bucur at oss.nxp.com> >Subject: [PATCH] drivers: net: qe: deselect QE when DM_ETH is enabled > >A compilation error appears when QE is compiled with DM_ETH >enabled: > >drivers/qe/uec.c: In function 'init_phy': >drivers/qe/uec.c:425:28: error: dereferencing pointer to incomplete type >'struct eth_device' > uec = (uec_private_t *)dev->priv; > ^~ >drivers/qe/uec.c: In function 'uec_initialize': >drivers/qe/uec.c:1357:43: error: invalid application of 'sizeof' to incomplete >type 'struct eth_device' > dev = (struct eth_device *)malloc(sizeof(struct eth_device)); > ^~~~~~ > >The patch disables CONFIG_QE when CONFIG_DM_ETH is set. > >Signed-off-by: Madalin Bucur <madalin.bucur at oss.nxp.com> >--- <snip> Patch applied on mpc85xx. Awaiting upstream Thanks Priyanka
diff --git a/drivers/qe/Kconfig b/drivers/qe/Kconfig index 864b36b..44c9f01 100644 --- a/drivers/qe/Kconfig +++ b/drivers/qe/Kconfig @@ -3,7 +3,7 @@ # config QE bool "Enable support for QUICC Engine" - depends on PPC + depends on PPC && !DM_ETH default y if ARCH_T1040 || ARCH_T1042 || ARCH_T1024 || ARCH_P1021 \ || ARCH_P1025 help
A compilation error appears when QE is compiled with DM_ETH enabled: drivers/qe/uec.c: In function 'init_phy': drivers/qe/uec.c:425:28: error: dereferencing pointer to incomplete type 'struct eth_device' uec = (uec_private_t *)dev->priv; ^~ drivers/qe/uec.c: In function 'uec_initialize': drivers/qe/uec.c:1357:43: error: invalid application of 'sizeof' to incomplete type 'struct eth_device' dev = (struct eth_device *)malloc(sizeof(struct eth_device)); ^~~~~~ The patch disables CONFIG_QE when CONFIG_DM_ETH is set. Signed-off-by: Madalin Bucur <madalin.bucur at oss.nxp.com> --- drivers/qe/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)