| Message ID | 20200424193733.498206-1-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | dabaabd3f17cfcd7f13569ca4fb8b543c08ba30c |
| Headers | show |
| Series | ARM: imx: imx8m: Do not warn about cpu-idle-states if missing | expand |
On Fri, Apr 24, 2020 at 4:37 PM Marek Vasut <marex at denx.de> wrote: > > If the cpu-idle-states is missing from the DT in the first place, do > not fail on removing in. Just move on and do not even print an error, > since not being able to remove something which is not there in the > first place is not an error and surely does not justify failing to > boot. > > Turn the surrounding prints into debugs to reduce the useless noise. > > Signed-off-by: Marek Vasut <marex at denx.de> > Cc: Frieder Schrempf <frieder.schrempf at kontron.de> > Cc: Fabio Estevam <festevam at gmail.com> > Cc: Peng Fan <peng.fan at nxp.com> > Cc: Stefano Babic <sbabic at denx.de> Reviewed-by: Fabio Estevam <festevam at gmail.com>
> If the cpu-idle-states is missing from the DT in the first place, do > not fail on removing in. Just move on and do not even print an error, > since not being able to remove something which is not there in the > first place is not an error and surely does not justify failing to > boot. > Turn the surrounding prints into debugs to reduce the useless noise. > Signed-off-by: Marek Vasut <marex at denx.de> > Cc: Frieder Schrempf <frieder.schrempf at kontron.de> > Cc: Fabio Estevam <festevam at gmail.com> > Cc: Peng Fan <peng.fan at nxp.com> > Cc: Stefano Babic <sbabic at denx.de> > Reviewed-by: Fabio Estevam <festevam at gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c index 7fcbd53f30..bbfc9c5576 100644 --- a/arch/arm/mach-imx/imx8m/soc.c +++ b/arch/arm/mach-imx/imx8m/soc.c @@ -364,16 +364,18 @@ int ft_system_setup(void *blob, bd_t *bd) if (nodeoff < 0) continue; /* Not found, skip it */ - printf("Found %s node\n", nodes_path[i]); + debug("Found %s node\n", nodes_path[i]); rc = fdt_delprop(blob, nodeoff, "cpu-idle-states"); + if (rc == -FDT_ERR_NOTFOUND) + continue; if (rc) { printf("Unable to update property %s:%s, err=%s\n", nodes_path[i], "status", fdt_strerror(rc)); return rc; } - printf("Remove %s:%s\n", nodes_path[i], + debug("Remove %s:%s\n", nodes_path[i], "cpu-idle-states"); } }
If the cpu-idle-states is missing from the DT in the first place, do not fail on removing in. Just move on and do not even print an error, since not being able to remove something which is not there in the first place is not an error and surely does not justify failing to boot. Turn the surrounding prints into debugs to reduce the useless noise. Signed-off-by: Marek Vasut <marex at denx.de> Cc: Frieder Schrempf <frieder.schrempf at kontron.de> Cc: Fabio Estevam <festevam at gmail.com> Cc: Peng Fan <peng.fan at nxp.com> Cc: Stefano Babic <sbabic at denx.de> --- arch/arm/mach-imx/imx8m/soc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)