diff mbox series

[v9,11/21] lib: Always set errno in hcreate_r

Message ID	20200423023320.1380090-12-seanga2@gmail.com
State	Superseded
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: seanga2 at gmail.com (Sean Anderson) Date: Wed, 22 Apr 2020 22:33:10 -0400 Subject: [PATCH v9 11/21] lib: Always set errno in hcreate_r In-Reply-To: <20200423023320.1380090-1-seanga2@gmail.com> References: <20200423023320.1380090-1-seanga2@gmail.com> Message-ID: <20200423023320.1380090-12-seanga2@gmail.com>
Series	riscv: Add Sipeed Maix support \| expand [v9,00/21] riscv: Add Sipeed Maix support [v9,01/21] clk: Always use the supplied struct clk [v9,02/21] clk: Check that ops of composite clock components exist before calling [v9,03/21] clk: Unconditionally recursively en-/dis-able clocks [v9,04/21] clk: Fix clk_get_by_* handling of index [v9,05/21] clk: Add K210 pll support [v9,06/21] clk: Add a bypass clock for K210 [v9,07/21] clk: Add K210 clock support [v9,08/21] dm: Add support for simple-pm-bus [v9,09/21] dm: Fix error handling for dev_read_addr_ptr [v9,10/21] reset: Add generic reset driver [v9,11/21] lib: Always set errno in hcreate_r [v9,12/21] riscv: Add headers for asm/global_data.h [v9,13/21] riscv: Clear pending interrupts before enabling IPIs [v9,14/21] riscv: Clean up IPI initialization code [v9,15/21] riscv: Add option to support RISC-V privileged spec 1.9 [v9,16/21] riscv: Allow use of reset drivers [v9,17/21] riscv: Try to get cpu frequency from a "clocks" node if it exists [v9,18/21] riscv: Enable cpu clock if it is present [v9,19/21] riscv: Add device tree for K210 and Sipeed Maix BitM [v9,20/21] doc: riscv: Add documentation for Sipeed Maix Bit [v9,21/21] riscv: Add Sipeed Maix support

Commit Message

Sean Anderson April 23, 2020, 2:33 a.m. UTC

This could give a confusing error message if it failed and didn't set
errno.

Signed-off-by: Sean Anderson <seanga2 at gmail.com>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
---

Changes in v5:
- New

 lib/hashtable.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/lib/hashtable.c b/lib/hashtable.c
index 907e8a642f..e9ac7e252e 100644
--- a/lib/hashtable.c
+++ b/lib/hashtable.c
@@ -109,8 +109,10 @@  int hcreate_r(size_t nel, struct hsearch_data *htab)
 	}
 
 	/* There is still another table active. Return with error. */
-	if (htab->table != NULL)
+	if (htab->table != NULL) {
+		__set_errno(EINVAL);
 		return 0;
+	}
 
 	/* Change nel to the first prime number not smaller as nel. */
 	nel |= 1;		/* make odd */
@@ -123,8 +125,10 @@  int hcreate_r(size_t nel, struct hsearch_data *htab)
 	/* allocate memory and zero out */
 	htab->table = (struct env_entry_node *)calloc(htab->size + 1,
 						sizeof(struct env_entry_node));
-	if (htab->table == NULL)
+	if (htab->table == NULL) {
+		__set_errno(ENOMEM);
 		return 0;
+	}
 
 	/* everything went alright */
 	return 1;