| Message ID | 20200409150840.v2.11.I39b6c927505684d4425384d0ede4c77a51bb65fb@changeid |
|---|---|
| State | Accepted |
| Commit | 9ef0ceb7308c710a54bc900ea57a233c9e716b2d |
| Headers | show |
| Series | buildman: Improve summary output | expand |
At present the board names shown with -l are separated by commas. This
makes it hard to double-click to select a particular board. Also it is not
possible to select all boards and paste them as arguments to a subsequent
buildman run, since buildman requires spaces to separate the list on the
command line, not commas.
Change the output format to use spaces instead of commas.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
Changes in v2:
- Add new patch to use spaces in the board list
tools/buildman/builder.py | 2 +-
tools/buildman/test.py | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
Applied to u-boot-dm, thanks!
diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index 7cbb1a6f628..e895ab73d8d 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -1253,7 +1253,7 @@ class Builder: for line in err_lines: boards = '' names = [board.target for board in line.boards] - board_str = ','.join(names) if names else '' + board_str = ' '.join(names) if names else '' if board_str: out = self.col.Color(colour, line.char + '(') out += self.col.Color(self.col.MAGENTA, board_str, diff --git a/tools/buildman/test.py b/tools/buildman/test.py index a64372dee36..a495df03036 100644 --- a/tools/buildman/test.py +++ b/tools/buildman/test.py @@ -249,9 +249,9 @@ class TestBuild(unittest.TestCase): new_lines.append(expect) return '\n'.join(new_lines) - boards1234 = 'board1,board2,board3,board4' if list_error_boards else '' - boards234 = 'board2,board3,board4' if list_error_boards else '' - boards34 = 'board3,board4' if list_error_boards else '' + boards1234 = 'board1 board2 board3 board4' if list_error_boards else '' + boards234 = 'board2 board3 board4' if list_error_boards else '' + boards34 = 'board3 board4' if list_error_boards else '' boards4 = 'board4' if list_error_boards else '' # Upstream commit: no errors
At present the board names shown with -l are separated by commas. This makes it hard to double-click to select a particular board. Also it is not possible to select all boards and paste them as arguments to a subsequent buildman run, since buildman requires spaces to separate the list on the command line, not commas. Change the output format to use spaces instead of commas. Signed-off-by: Simon Glass <sjg at chromium.org> --- Changes in v2: - Add new patch to use spaces in the board list tools/buildman/builder.py | 2 +- tools/buildman/test.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)