diff mbox series

cmd: eeprom: Staticize eeprom_i2c_bus

Message ID 20200407112904.23607-1-marex@denx.de
State Accepted
Commit ce9760715452341c43247f06fe016cd17d54897d
Headers show
Series cmd: eeprom: Staticize eeprom_i2c_bus | expand

Commit Message

Marek Vasut April 7, 2020, 11:29 a.m. UTC
The eeprom_i2c_bus is not used outside of this file, make it static.

Signed-off-by: Marek Vasut <marex at denx.de>
Cc: Heiko Schocher <hs at denx.de>
Cc: Tom Rini <trini at konsulko.com>
---
 cmd/eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Schocher April 8, 2020, 4:14 a.m. UTC | #1
Hello Marek,

Am 07.04.2020 um 13:29 schrieb Marek Vasut:
> The eeprom_i2c_bus is not used outside of this file, make it static.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>   cmd/eeprom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Heiko Schocher <hs at denx.de>

Good catch!

bye,
Heiko
Heiko Schocher April 21, 2020, 5:52 a.m. UTC | #2
Hello Marek,

Am 07.04.2020 um 13:29 schrieb Marek Vasut:
> The eeprom_i2c_bus is not used outside of this file, make it static.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>   cmd/eeprom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-i2c master, thanks!

bye,
Heiko
diff mbox series

Patch

diff --git a/cmd/eeprom.c b/cmd/eeprom.c
index 667149e2d4..792415ef93 100644
--- a/cmd/eeprom.c
+++ b/cmd/eeprom.c
@@ -61,7 +61,7 @@ 
 #endif
 
 #if defined(CONFIG_DM_I2C)
-int eeprom_i2c_bus;
+static int eeprom_i2c_bus;
 #endif
 
 __weak int eeprom_write_enable(unsigned dev_addr, int state)