| Message ID | 20200401101501.441502-1-pbrobinson@gmail.com |
|---|---|
| State | Accepted |
| Commit | bdf329e4a3ea1209a50d4cbe267ada41384eb750 |
| Headers | show |
| Series | efi_loader: enable RNG if DM_RNG is enabled | expand |
On Wed, 1 Apr 2020 at 15:45, Peter Robinson <pbrobinson at gmail.com> wrote: > Enable EFI_RNG_PROTOCOL by default if DM_RNG is set. > > Signed-off-by: Peter Robinson <pbrobinson at gmail.com> > --- > > I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config > has enabled both DM_RNG and UEFI. > Acked-by: Sughosh Ganu <sughosh.ganu at linaro.org> -sughosh > > lib/efi_loader/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index 9890144d41..b9a770281e 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND > > config EFI_RNG_PROTOCOL > bool "EFI_RNG_PROTOCOL support" > + default y if DM_RNG > depends on DM_RNG > help > Provide a EFI_RNG_PROTOCOL implementation using the hardware > random > -- > 2.26.0 > >
On 4/1/20 12:15 PM, Peter Robinson wrote: > Enable EFI_RNG_PROTOCOL by default if DM_RNG is set. > > Signed-off-by: Peter Robinson <pbrobinson at gmail.com> > --- > > I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config > has enabled both DM_RNG and UEFI. > > lib/efi_loader/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index 9890144d41..b9a770281e 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND > > config EFI_RNG_PROTOCOL > bool "EFI_RNG_PROTOCOL support" > + default y if DM_RNG Thank you for your patch. If you have 'depends on DM_RNG', there is not need for 'if DM RNG'. You can use scripts/get_maintainer.pl to determine all addressees for a patch (Alex was missing). Otherwise Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > depends on DM_RNG > help > Provide a EFI_RNG_PROTOCOL implementation using the hardware random >
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 9890144d41..b9a770281e 100644 --- a/lib/efi_loader/Kconfig +++ b/lib/efi_loader/Kconfig @@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND config EFI_RNG_PROTOCOL bool "EFI_RNG_PROTOCOL support" + default y if DM_RNG depends on DM_RNG help Provide a EFI_RNG_PROTOCOL implementation using the hardware random
Enable EFI_RNG_PROTOCOL by default if DM_RNG is set. Signed-off-by: Peter Robinson <pbrobinson at gmail.com> --- I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config has enabled both DM_RNG and UEFI. lib/efi_loader/Kconfig | 1 + 1 file changed, 1 insertion(+)