diff mbox series

[v5,14/33] gpio: sifive: Use generic reg read function

Message ID	20200228210552.615672-15-seanga2@gmail.com
State	Superseded
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: seanga2 at gmail.com (Sean Anderson) Date: Fri, 28 Feb 2020 16:05:32 -0500 Subject: [PATCH v5 14/33] gpio: sifive: Use generic reg read function In-Reply-To: <20200228210552.615672-1-seanga2@gmail.com> References: <20200228210552.615672-1-seanga2@gmail.com> Message-ID: <20200228210552.615672-15-seanga2@gmail.com>
Series	riscv: Add Sipeed Maix support \| expand [v5,00/33] riscv: Add Sipeed Maix support [v5,01/33] clk: Always use the supplied struct clk [v5,02/33] clk: Check that ops of composite clock components exist before calling [v5,03/33] clk: Unconditionally recursively en-/dis-able clocks [v5,04/33] clk: Add functions to register CCF clock structs [v5,05/33] clk: Add K210 pll support [v5,06/33] clk: Add a bypass clock for K210 [v5,07/33] clk: Add K210 clock support [v5,08/33] doc: Fix typo in FIT documentation [v5,09/33] dm: Add support for simple-pm-bus [v5,10/33] dm: Fix error handling for dev_read_addr_ptr [v5,11/33] reset: Add generic reset driver [v5,12/33] lib: Always set errno in hcreate_r [v5,13/33] pinctrl: Add support for Kendryte K210 FPIOA [v5,14/33] gpio: sifive: Use generic reg read function [v5,15/33] gpio: dw: Fix warnings about casting int to pointer [v5,16/33] gpio: dw: Add a trailing underscore to generated name [v5,17/33] gpio: dw: Return output value when direction is out [v5,18/33] led: gpio: Default to using node name if label is absent [v5,19/33] spi: dw: Add device tree properties for fields in CTRL1 [v5,20/33] spi: dw: Rename "cs-gpio" to "cs-gpios" [v5,21/33] spi: dw: Use generic function to read reg address [v5,22/33] spi: dw: Speed up transfer loops [v5,23/33] spi: dw: Properly set rx_end when not recieving [v5,24/33] spi: dw: Add mem_ops [v5,25/33] wdt: Move asm/utils.h to log2.h [v5,26/33] riscv: Add headers for asm/global_data.h [v5,27/33] riscv: Fix race conditions when initializing IPI [v5,28/33] riscv: Add option to support RISC-V privileged spec 1.9 [v5,29/33] riscv: Allow use of reset drivers [v5,30/33] riscv: Try to get cpu frequency from a "clocks" node if it exists [v5,31/33] riscv: Enable cpu clock if it is present [v5,32/33] riscv: Add device tree for K210 and Sipeed Maix BitM [v5,33/33] riscv: Add Sipeed Maix support

Commit Message

Sean Anderson Feb. 28, 2020, 9:05 p.m. UTC

Using an fdt-specific function causes problems with a live tree.

Signed-off-by: Sean Anderson <seanga2 at gmail.com>
---

Changes in v5:
- New

 drivers/gpio/sifive-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng March 2, 2020, 2:24 a.m. UTC | #1

On Sat, Feb 29, 2020 at 5:06 AM Sean Anderson <seanga2 at gmail.com> wrote:
>
> Using an fdt-specific function causes problems with a live tree.
>
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> ---
>
> Changes in v5:
> - New
>
>  drivers/gpio/sifive-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

diff mbox series

Patch

diff --git a/drivers/gpio/sifive-gpio.c b/drivers/gpio/sifive-gpio.c
index 76d5a1d34e..111f759d2e 100644
--- a/drivers/gpio/sifive-gpio.c
+++ b/drivers/gpio/sifive-gpio.c
@@ -158,7 +158,7 @@  static int sifive_gpio_ofdata_to_platdata(struct udevice *dev)
 	struct sifive_gpio_platdata *plat = dev_get_platdata(dev);
 	fdt_addr_t addr;
 
-	addr = devfdt_get_addr(dev);
+	addr = dev_read_addr(dev);
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;