diff mbox series

[2/2] rockchip: evb-rv1108: Use syscon API to get grf base

Message ID 20200219014606.18515-2-kever.yang@rock-chips.com
State Accepted
Commit 9cec3367087bcdcf6f583e60b95243d0d5e9ae92
Headers show
Series [1/2] rockchip: elgin-rv1108: Use syscon API to get grf base | expand

Commit Message

Kever Yang Feb. 19, 2020, 1:46 a.m. UTC
Use syscon API to get grf base instead of get from dts.

Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
---

 board/rockchip/evb_rv1108/evb_rv1108.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Simon Glass Feb. 20, 2020, 3:04 a.m. UTC | #1
On Tue, 18 Feb 2020 at 18:46, Kever Yang <kever.yang at rock-chips.com> wrote:
>
> Use syscon API to get grf base instead of get from dts.
>
> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> ---
>
>  board/rockchip/evb_rv1108/evb_rv1108.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

You might consider putting this code in a BOARD driver.
diff mbox series

Patch

diff --git a/board/rockchip/evb_rv1108/evb_rv1108.c b/board/rockchip/evb_rv1108/evb_rv1108.c
index 733f29376e..5d622c3737 100644
--- a/board/rockchip/evb_rv1108/evb_rv1108.c
+++ b/board/rockchip/evb_rv1108/evb_rv1108.c
@@ -5,8 +5,9 @@ 
  */
 
 #include <common.h>
+#include <syscon.h>
 #include <asm/io.h>
-#include <fdtdec.h>
+#include <asm/arch-rockchip/clock.h>
 #include <asm/arch-rockchip/grf_rv1108.h>
 #include <asm/arch-rockchip/hardware.h>
 
@@ -14,7 +15,6 @@  DECLARE_GLOBAL_DATA_PTR;
 
 int mach_cpu_init(void)
 {
-	int node;
 	struct rv1108_grf *grf;
 	enum {
 		GPIO3C3_SHIFT           = 6,
@@ -34,8 +34,7 @@  int mach_cpu_init(void)
 		GPIO2D1_UART2_SIN_M0,
 	};
 
-	node = fdt_node_offset_by_compatible(gd->fdt_blob, -1, "rockchip,rv1108-grf");
-	grf = (struct rv1108_grf *)fdtdec_get_addr(gd->fdt_blob, node, "reg");
+	grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
 
 	/*evb board use UART2 m0 for debug*/
 	rk_clrsetreg(&grf->gpio2d_iomux,