| Message ID | 20200215202200.15150-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 38a2a48cd9e4697cb8942e56212610d4248ea34c |
| Headers | show |
| Series | [1/1] x86: remove dead code in intel_clk_get_rate() | expand |
On Sat, 15 Feb 2020 21:22:00 +0100 Heinrich Schuchardt <xypron.glpk at gmx.de> wrote: > If all branches of a switch statement have a return instruction, all > subsequent lines are unreachable. > > Identified with cppcheck. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > --- > drivers/clk/intel/clk_intel.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/clk/intel/clk_intel.c > b/drivers/clk/intel/clk_intel.c index d2e15491a3..b633934d90 100644 > --- a/drivers/clk/intel/clk_intel.c > +++ b/drivers/clk/intel/clk_intel.c > @@ -11,8 +11,6 @@ > > static ulong intel_clk_get_rate(struct clk *clk) > { > - ulong rate; > - > switch (clk->id) { > case CLK_I2C: > /* Hard-coded to 133MHz on current platforms */ > @@ -20,8 +18,6 @@ static ulong intel_clk_get_rate(struct clk *clk) > default: > return -ENODEV; > } > - > - return rate; > } > > static struct clk_ops intel_clk_ops = { > -- > 2.25.0 > Reviewed-by: Lukasz Majewski <lukma at denx.de> Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200216/04d7158d/attachment.sig>
On Sat, 15 Feb 2020 at 13:22, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote: > > If all branches of a switch statement have a return instruction, all > subsequent lines are unreachable. > > Identified with cppcheck. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > --- > drivers/clk/intel/clk_intel.c | 4 ---- > 1 file changed, 4 deletions(-) Reviewed-by: Simon Glass <sjg at chromium.org>
On Sun, Feb 16, 2020 at 4:22 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote: > > If all branches of a switch statement have a return instruction, all > subsequent lines are unreachable. > > Identified with cppcheck. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > --- > drivers/clk/intel/clk_intel.c | 4 ---- > 1 file changed, 4 deletions(-) > applied to u-boot-x86, thanks!
diff --git a/drivers/clk/intel/clk_intel.c b/drivers/clk/intel/clk_intel.c index d2e15491a3..b633934d90 100644 --- a/drivers/clk/intel/clk_intel.c +++ b/drivers/clk/intel/clk_intel.c @@ -11,8 +11,6 @@ static ulong intel_clk_get_rate(struct clk *clk) { - ulong rate; - switch (clk->id) { case CLK_I2C: /* Hard-coded to 133MHz on current platforms */ @@ -20,8 +18,6 @@ static ulong intel_clk_get_rate(struct clk *clk) default: return -ENODEV; } - - return rate; } static struct clk_ops intel_clk_ops = {
If all branches of a switch statement have a return instruction, all subsequent lines are unreachable. Identified with cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> --- drivers/clk/intel/clk_intel.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.25.0