diff mbox series

[v1,2/2] ARM: dts: imx8mm-verdin: drop rgmii_rxc_dly/txc_dly

Message ID 20200214123644.3380-2-igor.opaniuk@gmail.com
State New
Headers show
Series [v1,1/2] ARM: dts: imx8mm-verdin: dm-spl for pinctrl_usdhc1 node | expand

Commit Message

Igor Opaniuk Feb. 14, 2020, 12:36 p.m. UTC
From: Max Krummenacher <max.krummenacher at toradex.com>

The FEC in the i.MX8MM doesn't support this feature. So don't pretend one
can use it.

Signed-off-by: Max Krummenacher <max.krummenacher at toradex.com>
Signed-off-by: Igor Opaniuk <igor.opaniuk at toradex.com>
---

 arch/arm/dts/imx8mm-verdin.dts | 2 --
 1 file changed, 2 deletions(-)

Comments

Peng Fan Feb. 14, 2020, 1:06 p.m. UTC | #1
> Subject: [PATCH v1 2/2] ARM: dts: imx8mm-verdin: drop
> rgmii_rxc_dly/txc_dly
> 
> From: Max Krummenacher <max.krummenacher at toradex.com>
> 
> The FEC in the i.MX8MM doesn't support this feature. So don't pretend one
> can use it.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher at toradex.com>
> Signed-off-by: Igor Opaniuk <igor.opaniuk at toradex.com>

Acked-by: Peng Fan <peng.fan at nxp.com>

> ---
> 
>  arch/arm/dts/imx8mm-verdin.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/dts/imx8mm-verdin.dts
> b/arch/arm/dts/imx8mm-verdin.dts index 2980053e82..b86f46e03e 100644
> --- a/arch/arm/dts/imx8mm-verdin.dts
> +++ b/arch/arm/dts/imx8mm-verdin.dts
> @@ -153,8 +153,6 @@
> 
>  &fec1 {
>  	fsl,magic-packet;
> -	fsl,rgmii_rxc_dly;
> -	fsl,rgmii_txc_dly;
>  	phy-handle = <&ethphy0>;
>  	phy-mode = "rgmii";
>  	phy-supply = <&reg_ethphy>;
> --
> 2.17.1
Oleksandr Suvorov Feb. 14, 2020, 1:28 p.m. UTC | #2
On Fri, Feb 14, 2020 at 2:37 PM Igor Opaniuk <igor.opaniuk at gmail.com> wrote:
>
> From: Max Krummenacher <max.krummenacher at toradex.com>
>
> The FEC in the i.MX8MM doesn't support this feature. So don't pretend one
> can use it.
>
> Signed-off-by: Max Krummenacher <max.krummenacher at toradex.com>
> Signed-off-by: Igor Opaniuk <igor.opaniuk at toradex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov at toradex.com>

> ---
>
>  arch/arm/dts/imx8mm-verdin.dts | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/dts/imx8mm-verdin.dts b/arch/arm/dts/imx8mm-verdin.dts
> index 2980053e82..b86f46e03e 100644
> --- a/arch/arm/dts/imx8mm-verdin.dts
> +++ b/arch/arm/dts/imx8mm-verdin.dts
> @@ -153,8 +153,6 @@
>
>  &fec1 {
>         fsl,magic-packet;
> -       fsl,rgmii_rxc_dly;
> -       fsl,rgmii_txc_dly;
>         phy-handle = <&ethphy0>;
>         phy-mode = "rgmii";
>         phy-supply = <&reg_ethphy>;
> --
> 2.17.1
>
Stefano Babic March 10, 2020, 3:32 p.m. UTC | #3
> From: Max Krummenacher <max.krummenacher at toradex.com>
> The FEC in the i.MX8MM doesn't support this feature. So don't pretend one
> can use it.
> Signed-off-by: Max Krummenacher <max.krummenacher at toradex.com>
> Signed-off-by: Igor Opaniuk <igor.opaniuk at toradex.com>
> Acked-by: Peng Fan <peng.fan at nxp.com>
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov at toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/dts/imx8mm-verdin.dts b/arch/arm/dts/imx8mm-verdin.dts
index 2980053e82..b86f46e03e 100644
--- a/arch/arm/dts/imx8mm-verdin.dts
+++ b/arch/arm/dts/imx8mm-verdin.dts
@@ -153,8 +153,6 @@ 
 
 &fec1 {
 	fsl,magic-packet;
-	fsl,rgmii_rxc_dly;
-	fsl,rgmii_txc_dly;
 	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii";
 	phy-supply = <&reg_ethphy>;