[4.9,090/165] remoteproc: Initialize rproc_class before use

Message ID	20200227132244.450160696@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <SRS0=mLYK=4P=vger.kernel.org=stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Brandon Maier <brandon.maier@rockwellcollins.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Sasha Levin <sashal@kernel.org> Subject: [PATCH 4.9 090/165] remoteproc: Initialize rproc_class before use Date: Thu, 27 Feb 2020 14:36:04 +0100 Message-Id: <20200227132244.450160696@linuxfoundation.org> In-Reply-To: <20200227132230.840899170@linuxfoundation.org> References: <20200227132230.840899170@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk
Series	None \| expand [4.9,002/165] KVM: x86: emulate RDPID [4.9,003/165] ALSA: hda: Use scnprintf() for printing texts for sysfs/procfs [4.9,004/165] ecryptfs: fix a memory leak bug in parse_tag_1_packet() [4.9,006/165] ALSA: usb-audio: Apply sample rate quirk for Audioengine D1 [4.9,007/165] ext4: dont assume that mmp_nodename/bdevname have NUL [4.9,010/165] Btrfs: fix race between using extent maps and merging them [4.9,011/165] btrfs: log message when rw remount is attempted with unclean tree-log [4.9,012/165] perf/x86/amd: Add missing L2 misses event spec to AMD Family 17hs event map [4.9,015/165] perf/x86/intel: Fix inaccurate period in context switch for auto-reload [4.9,016/165] hwmon: (pmbus/ltc2978) Fix PMBus polling of MFR_COMMON definitions. [4.9,021/165] Revert "KVM: VMX: Add non-canonical check on writes to RTIT address MSRs" [4.9,022/165] drm/gma500: Fixup fbdev stolen size usage evaluation [4.9,024/165] brcmfmac: Fix use after free in brcmf_sdio_readframes() [4.9,025/165] gianfar: Fix TX timestamping with a stacked DSA driver [4.9,027/165] pxa168fb: Fix the function used to release some memory in an error handling path [4.9,029/165] powerpc/powernv/iov: Ensure the pdn for VFs always contains a valid PE number [4.9,030/165] gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_irq_map/unmap() [4.9,033/165] efi/x86: Map the entire EFI vendor string before copying it [4.9,035/165] sparc: Add .exit.data section. [4.9,037/165] usb: gadget: udc: fix possible sleep-in-atomic-context bugs in gr_probe() [4.9,039/165] x86/sysfb: Fix check for bad VRAM size [4.9,042/165] ext4, jbd2: ensure panic when aborting with zero errno [4.9,044/165] clk: qcom: rcg2: Dont crash if our parent cant be found; return an error [4.9,046/165] regulator: rk808: Lower log level on optional GPIOs being not available [4.9,048/165] PCI/IOV: Fix memory leak in pci_iov_add_virtfn() [4.9,051/165] reiserfs: Fix spurious unlock in reiserfs_fill_super() error handling [4.9,053/165] b43legacy: Fix -Wcast-function-type [4.9,054/165] ipw2x00: Fix -Wcast-function-type [4.9,057/165] orinoco: avoid assertion in case of NULL pointer [4.9,058/165] ACPICA: Disassembler: create buffer fields in ACPI_PARSE_LOAD_PASS1 [4.9,062/165] x86/vdso: Provide missing include file [4.9,063/165] PM / devfreq: rk3399_dmc: Add COMPILE_TEST and HAVE_ARM_SMCCC dependency [4.9,065/165] RDMA/rxe: Fix error type of mmap_offset [4.9,067/165] tools lib api fs: Fix gcc9 stringop-truncation compilation error [4.9,070/165] soc/tegra: fuse: Correct straps address for older Tegra124 device trees [4.9,071/165] rcu: Use WRITE_ONCE() for assignments to ->pprev for hlist_nulls [4.9,072/165] Input: edt-ft5x06 - work around first register access error [4.9,074/165] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m [4.9,076/165] tty: synclink_gt: Adjust indentation in several functions [4.9,078/165] driver core: Print device when resources present in really_probe() [4.9,081/165] drm/nouveau: Fix copy-paste error in nouveau_fence_wait_uevent_handler [4.9,083/165] usb: musb: omap2430: Get rid of musb .set_vbus for omap2430 glue [4.9,086/165] arm64: fix alternatives with LLVMs integrated assembler [4.9,087/165] pwm: omap-dmtimer: Remove PWM chip in .remove before making it unfunctional [4.9,088/165] cmd64x: potential buffer overflow in cmd64x_program_timings() [4.9,089/165] ide: serverworks: potential overflow in svwks_set_pio_mode() [4.9,090/165] remoteproc: Initialize rproc_class before use [4.9,093/165] driver core: platform: fix u32 greater or equal to zero comparison [4.9,094/165] ALSA: hda - Add docking station support for Lenovo Thinkpad T420s [4.9,097/165] ARM: 8951/1: Fix Kexec compilation issue. [4.9,098/165] hostap: Adjust indentation in prism2_hostapd_add_sta [4.9,101/165] irqchip/gic-v3: Only provision redistributors that are enabled in ACPI [4.9,102/165] drm/nouveau/disp/nv50-: prevent oops when no channel method map provided [4.9,105/165] radeon: insert 10ms sleep in dce5_crtc_load_lut [4.9,107/165] lib/scatterlist.c: adjust indentation in __sg_alloc_table [4.9,109/165] bcache: explicity type cast in bset_bkey_last() [4.9,111/165] iwlwifi: mvm: Fix thermal zone registration [4.9,114/165] help_next should increase position index [4.9,116/165] enic: prevent waking up stopped tx queues over watchdog reset [4.9,119/165] floppy: check FDC index for errors before assigning it [4.9,120/165] vt: selection, handle pending signals in paste_selection [4.9,122/165] staging: vt6656: fix sign of rx_dbm to bb_pre_ed_rssi. [4.9,125/165] USB: Fix novation SourceControl XL after suspend [4.9,129/165] x86/mce/amd: Publish the bank pointer only after setup has succeeded [4.9,132/165] tty: serial: imx: setup the correct sg entry for tx dma [4.9,133/165] Revert "ipc,sem: remove uneeded sem_undo_list lock usage in exit_sem()" [4.9,135/165] KVM: x86: dont notify userspace IOAPIC on edge-triggered interrupt EOI [4.9,136/165] VT_RESIZEX: get rid of field-by-field copyin [4.9,138/165] powerpc/tm: P9 disable transactionally suspended sigcontexts [4.9,141/165] lib/stackdepot: Fix outdated comments [4.9,143/165] KVM: nVMX: Dont emulate instructions in guest mode [4.9,144/165] netfilter: xt_bpf: add overflow checks [4.9,146/165] ext4: add cond_resched() to __ext4_find_entry() [4.9,147/165] ext4: fix mount failure with quota configured as module [4.9,150/165] KVM: nVMX: Refactor IO bitmap checks into helper function [4.9,152/165] KVM: apic: avoid calculating pending eoi from an uninitialized val [4.9,153/165] Btrfs: fix btrfs_wait_ordered_range() so that it waits for all ordered extents [4.9,155/165] scsi: Revert "target: iscsi: Wait for all commands to finish before freeing a session" [4.9,156/165] usb: gadget: composite: Fix bMaxPower for SuperSpeedPlus [4.9,159/165] ALSA: rawmidi: Avoid bit fields for state flags [4.9,161/165] ALSA: seq: Fix concurrent access to queue current tick/time [4.9,162/165] netfilter: xt_hashlimit: limit the max size of hashtable [4.9,165/165] s390/mm: Explicitly compare PAGE_DEFAULT_KEY against zero in storage_key_init_range

Message ID

20200227132244.450160696@linuxfoundation.org

State

Superseded

Headers

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org,
	Brandon Maier <brandon.maier@rockwellcollins.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH 4.9 090/165] remoteproc: Initialize rproc_class before use
Date: Thu, 27 Feb 2020 14:36:04 +0100
Message-Id: <20200227132244.450160696@linuxfoundation.org>
In-Reply-To: <20200227132230.840899170@linuxfoundation.org>
References: <20200227132230.840899170@linuxfoundation.org>
User-Agent: quilt/0.66
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
Precedence: bulk

Series

None | expand

Commit Message

Greg KH Feb. 27, 2020, 1:36 p.m. UTC

From: Brandon Maier <brandon.maier@rockwellcollins.com>

[ Upstream commit a8f40111d184098cd2b3dc0c7170c42250a5fa09 ]

The remoteproc_core and remoteproc drivers all initialize with module_init().
However remoteproc drivers need the rproc_class during their probe. If one of
the remoteproc drivers runs init and gets through probe before
remoteproc_init() runs, a NULL pointer access of rproc_class's `glue_dirs`
spinlock occurs.

> Unable to handle kernel NULL pointer dereference at virtual address 000000dc
> pgd = c0004000
> [000000dc] *pgd=00000000
> Internal error: Oops: 5 [#1] PREEMPT ARM
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper Tainted: G        W       4.14.106-rt56 #1
> Hardware name: Generic OMAP36xx (Flattened Device Tree)
> task: c6050000 task.stack: c604a000
> PC is at rt_spin_lock+0x40/0x6c
> LR is at rt_spin_lock+0x28/0x6c
> pc : [<c0523c90>]    lr : [<c0523c78>]    psr: 60000013
> sp : c604bdc0  ip : 00000000  fp : 00000000
> r10: 00000000  r9 : c61c7c10  r8 : c6269c20
> r7 : c0905888  r6 : c6269c20  r5 : 00000000  r4 : 000000d4
> r3 : 000000dc  r2 : c6050000  r1 : 00000002  r0 : 000000d4
> Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
...
> [<c0523c90>] (rt_spin_lock) from [<c03b65a4>] (get_device_parent+0x54/0x17c)
> [<c03b65a4>] (get_device_parent) from [<c03b6bec>] (device_add+0xe0/0x5b4)
> [<c03b6bec>] (device_add) from [<c042adf4>] (rproc_add+0x18/0xd8)
> [<c042adf4>] (rproc_add) from [<c01110e4>] (my_rproc_probe+0x158/0x204)
> [<c01110e4>] (my_rproc_probe) from [<c03bb6b8>] (platform_drv_probe+0x34/0x70)
> [<c03bb6b8>] (platform_drv_probe) from [<c03b9dd4>] (driver_probe_device+0x2c8/0x420)
> [<c03b9dd4>] (driver_probe_device) from [<c03ba02c>] (__driver_attach+0x100/0x11c)
> [<c03ba02c>] (__driver_attach) from [<c03b7d08>] (bus_for_each_dev+0x7c/0xc0)
> [<c03b7d08>] (bus_for_each_dev) from [<c03b910c>] (bus_add_driver+0x1cc/0x264)
> [<c03b910c>] (bus_add_driver) from [<c03ba714>] (driver_register+0x78/0xf8)
> [<c03ba714>] (driver_register) from [<c010181c>] (do_one_initcall+0x100/0x190)
> [<c010181c>] (do_one_initcall) from [<c0800de8>] (kernel_init_freeable+0x130/0x1d0)
> [<c0800de8>] (kernel_init_freeable) from [<c051eee8>] (kernel_init+0x8/0x114)
> [<c051eee8>] (kernel_init) from [<c01175b0>] (ret_from_fork+0x14/0x24)
> Code: e2843008 e3c2203f f5d3f000 e5922010 (e193cf9f)
> ---[ end trace 0000000000000002 ]---

Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
Link: https://lore.kernel.org/r/20190530225223.136420-1-brandon.maier@rockwellcollins.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/remoteproc/remoteproc_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index c6bfb3496684e..b99780574044a 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1488,7 +1488,7 @@  static int __init remoteproc_init(void)
 
 	return 0;
 }
-module_init(remoteproc_init);
+subsys_initcall(remoteproc_init);
 
 static void __exit remoteproc_exit(void)
 {

[4.9,090/165] remoteproc: Initialize rproc_class before use

Commit Message

Patch