| Message ID | 20200417040202.O_VbU09Pt%akpm@linux-foundation.org |
|---|---|
| State | New |
| Headers | show |
| Series | + coredump-fix-null-pointer-dereference-on-coredump.patch added to -mm tree | expand |
--- a/fs/coredump.c~coredump-fix-null-pointer-dereference-on-coredump +++ a/fs/coredump.c @@ -211,6 +211,8 @@ static int format_corename(struct core_n return -ENOMEM; (*argv)[(*argc)++] = 0; ++pat_ptr; + if (!(*pat_ptr)) + return -ENOMEM; } /* Repeat as long as we have more pattern to process and more output
The patch titled Subject: coredump: fix null pointer dereference on coredump has been added to the -mm tree. Its filename is coredump-fix-null-pointer-dereference-on-coredump.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/coredump-fix-null-pointer-dereference-on-coredump.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/coredump-fix-null-pointer-dereference-on-coredump.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Subject: coredump: fix null pointer dereference on coredump If the core_pattern is set to "|" and any process segfaults then we get a null pointer derefernce while trying to coredump. The call stack shows: [ 108.212680] RIP: 0010:do_coredump+0x628/0x11c0 When the core_pattern has only "|" there is no use of trying the coredump and we can check that while formating the corename and exit with an error. After this change I get: [ 48.453756] format_corename failed [ 48.453758] Aborting core Link: http://lkml.kernel.org/r/20200416194612.21418-1-sudipm.mukherjee@gmail.com Fixes: 315c69261dd3 ("coredump: split pipe command whitespace before expanding template") Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Reported-by: Matthew Ruffell <matthew.ruffell@canonical.com> Cc: Paul Wise <pabs3@bonedaddy.net> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Neil Horman <nhorman@tuxdriver.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- fs/coredump.c | 2 ++ 1 file changed, 2 insertions(+)