| Message ID | 1387471503-20794-1-git-send-email-julien.grall@linaro.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
Julien Grall writes ("[PATCH] tools/libx: xl uptime doesn't require argument"):
> The current behavior is:
>
> 42sh> xl uptime
> 'xl uptime' requires at least 1 argument.
>
> Usage: xl [-v] uptime [-s] [Domain]
>
> The normal behavior should list uptime for each domain when there is no
> parameters.
Maybe I'm confused, but the current code seems not to do that even if
you change option parsing spec. Is there part of your patch missing ?
Thanks,
Ian.
On 12/19/2013 04:54 PM, Ian Jackson wrote: > Julien Grall writes ("[PATCH] tools/libx: xl uptime doesn't require argument"): >> The current behavior is: >> >> 42sh> xl uptime >> 'xl uptime' requires at least 1 argument. >> >> Usage: xl [-v] uptime [-s] [Domain] >> >> The normal behavior should list uptime for each domain when there is no >> parameters. > > Maybe I'm confused, but the current code seems not to do that even if > you change option parsing spec. Is there part of your patch missing ? No, the last argument of SWITCH_FOREACH_OPT indicates how many argument is required. With this simple patch I can do: 42sh> xl uptime Name ID Uptime Domain-0 0 12:25:52
Julien Grall writes ("Re: [PATCH] tools/libx: xl uptime doesn't require argument"):
> On 12/19/2013 04:54 PM, Ian Jackson wrote:
> > Julien Grall writes ("[PATCH] tools/libx: xl uptime doesn't require argument"):
> >> The normal behavior should list uptime for each domain when there is no
> >> parameters.
...
> No, the last argument of SWITCH_FOREACH_OPT indicates how many argument
> is required.
>
> With this simple patch I can do:
> 42sh> xl uptime
> Name ID Uptime
> Domain-0 0 12:25:52
Oh wait I see the "nb_domains==0" case in print_uptime. Foolish me
for expecting xl's logic to have any kind of rationale.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
And added to my backport list.
Ian.
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 078f7a7..dce2699 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -6285,7 +6285,7 @@ int main_uptime(int argc, char **argv) int nb_doms = 0; int opt; - SWITCH_FOREACH_OPT(opt, "s", NULL, "uptime", 1) { + SWITCH_FOREACH_OPT(opt, "s", NULL, "uptime", 0) { case 's': short_mode = 1; break;
The current behavior is: 42sh> xl uptime 'xl uptime' requires at least 1 argument. Usage: xl [-v] uptime [-s] [Domain] The normal behavior should list uptime for each domain when there is no parameters. Signed-off-by: Julien Grall <julien.grall@linaro.org> --- tools/libxl/xl_cmdimpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)