diff mbox

arm64: KVM: Force undefined exception for Guest SMC intructions

Message ID 1386864747-29006-2-git-send-email-anup.patel@linaro.org
State Accepted
Commit e5cf9dcdbfd26cd4e1991db08755da900454efeb
Headers show

Commit Message

Anup Patel Dec. 12, 2013, 4:12 p.m. UTC 
The SMC-based PSCI emulation for Guest is going to be very different
from the in-kernel HVC-based PSCI emulation hence for now just inject
undefined exception when Guest executes SMC instruction.

Signed-off-by: Anup Patel <anup.patel@linaro.org>
Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
---
 arch/arm64/kvm/handle_exit.c |    3 ---
 1 file changed, 3 deletions(-)

Comments

Marc Zyngier Dec. 13, 2013, 5:36 p.m. UTC | #1 
On 12/12/13 16:12, Anup Patel wrote:
> The SMC-based PSCI emulation for Guest is going to be very different
> from the in-kernel HVC-based PSCI emulation hence for now just inject
> undefined exception when Guest executes SMC instruction.
> 
> Signed-off-by: Anup Patel <anup.patel@linaro.org>
> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.

> ---
>  arch/arm64/kvm/handle_exit.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c
> index 8da5606..df84d7b 100644
> --- a/arch/arm64/kvm/handle_exit.c
> +++ b/arch/arm64/kvm/handle_exit.c
> @@ -39,9 +39,6 @@ static int handle_hvc(struct kvm_vcpu *vcpu, struct kvm_run *run)
>  
>  static int handle_smc(struct kvm_vcpu *vcpu, struct kvm_run *run)
>  {
> -	if (kvm_psci_call(vcpu))
> -		return 1;
> -
>  	kvm_inject_undefined(vcpu);
>  	return 1;
>  }
>
Christoffer Dall Dec. 13, 2013, 7:16 p.m. UTC | #2 
On Thu, Dec 12, 2013 at 09:42:23PM +0530, Anup Patel wrote:
> The SMC-based PSCI emulation for Guest is going to be very different
> from the in-kernel HVC-based PSCI emulation hence for now just inject
> undefined exception when Guest executes SMC instruction.

Acked-by: Christoffer Dall <christoffer.dall@linaro.org>

> 
> Signed-off-by: Anup Patel <anup.patel@linaro.org>
> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
> ---
>  arch/arm64/kvm/handle_exit.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c
> index 8da5606..df84d7b 100644
> --- a/arch/arm64/kvm/handle_exit.c
> +++ b/arch/arm64/kvm/handle_exit.c
> @@ -39,9 +39,6 @@ static int handle_hvc(struct kvm_vcpu *vcpu, struct kvm_run *run)
>  
>  static int handle_smc(struct kvm_vcpu *vcpu, struct kvm_run *run)
>  {
> -	if (kvm_psci_call(vcpu))
> -		return 1;
> -
>  	kvm_inject_undefined(vcpu);
>  	return 1;
>  }
> -- 
> 1.7.9.5
>
diff mbox

Patch

diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c
index 8da5606..df84d7b 100644
--- a/arch/arm64/kvm/handle_exit.c
+++ b/arch/arm64/kvm/handle_exit.c
@@ -39,9 +39,6 @@  static int handle_hvc(struct kvm_vcpu *vcpu, struct kvm_run *run)
 
 static int handle_smc(struct kvm_vcpu *vcpu, struct kvm_run *run)
 {
-	if (kvm_psci_call(vcpu))
-		return 1;
-
 	kvm_inject_undefined(vcpu);
 	return 1;
 }