| Message ID | c5d802f9efd94a2fafea738d370feff85272bf9a.1384337302.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Wednesday, November 13, 2013 03:39:23 PM Viresh Kumar wrote: > With a recent change "d4019f0 cpufreq: move freq change notifications to cpufreq > core" few variables (r & ret) are removed by mistake and hence these warnings: > > drivers/cpufreq/omap-cpufreq.c: In function omap_target: > drivers/cpufreq/omap-cpufreq.c:64:2: error: ret undeclared (first use in this function) > drivers/cpufreq/omap-cpufreq.c:64:2: note: each undeclared identifier is reported only once for each function it appears in > drivers/cpufreq/omap-cpufreq.c:94:3: error: r undeclared (first use in this function) > drivers/cpufreq/omap-cpufreq.c:116:1: warning: control reaches end of non-void function [-Wreturn-type] > > Lets fix them by declaring those variables again. > > Reported-by: Sebastian Capella <sebastian.capella@linaro.org> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Queued up for the next PM pull request, thanks! > --- > drivers/cpufreq/omap-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c > index be6d143..a0acd0b 100644 > --- a/drivers/cpufreq/omap-cpufreq.c > +++ b/drivers/cpufreq/omap-cpufreq.c > @@ -53,6 +53,7 @@ static unsigned int omap_getspeed(unsigned int cpu) > > static int omap_target(struct cpufreq_policy *policy, unsigned int index) > { > + int r, ret; > struct dev_pm_opp *opp; > unsigned long freq, volt = 0, volt_old = 0, tol = 0; > unsigned int old_freq, new_freq; >
diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c index be6d143..a0acd0b 100644 --- a/drivers/cpufreq/omap-cpufreq.c +++ b/drivers/cpufreq/omap-cpufreq.c @@ -53,6 +53,7 @@ static unsigned int omap_getspeed(unsigned int cpu) static int omap_target(struct cpufreq_policy *policy, unsigned int index) { + int r, ret; struct dev_pm_opp *opp; unsigned long freq, volt = 0, volt_old = 0, tol = 0; unsigned int old_freq, new_freq;
With a recent change "d4019f0 cpufreq: move freq change notifications to cpufreq core" few variables (r & ret) are removed by mistake and hence these warnings: drivers/cpufreq/omap-cpufreq.c: In function omap_target: drivers/cpufreq/omap-cpufreq.c:64:2: error: ret undeclared (first use in this function) drivers/cpufreq/omap-cpufreq.c:64:2: note: each undeclared identifier is reported only once for each function it appears in drivers/cpufreq/omap-cpufreq.c:94:3: error: r undeclared (first use in this function) drivers/cpufreq/omap-cpufreq.c:116:1: warning: control reaches end of non-void function [-Wreturn-type] Lets fix them by declaring those variables again. Reported-by: Sebastian Capella <sebastian.capella@linaro.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/omap-cpufreq.c | 1 + 1 file changed, 1 insertion(+)