| Message ID | c79ae2ab0a5a3946fcd0e68c855742f06f695f0f.1379779777.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 09/22/2013 03:21 AM, Viresh Kumar wrote: > Few statements in cpuidle_idle_call() are broken into multiple lines, whereas > they can actually come in a single line. Convert those to single line. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> I splitted these lines because they have 81 cols. > --- > drivers/cpuidle/cpuidle.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c > index ed67e3c..43d5836 100644 > --- a/drivers/cpuidle/cpuidle.c > +++ b/drivers/cpuidle/cpuidle.c > @@ -145,8 +145,7 @@ int cpuidle_idle_call(void) > broadcast = drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP; > > if (broadcast) > - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, > - &dev->cpu); > + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu); > > if (cpuidle_state_is_coupled(dev, drv, next_state)) > entered_state = cpuidle_enter_state_coupled(dev, drv, > @@ -155,8 +154,7 @@ int cpuidle_idle_call(void) > entered_state = cpuidle_enter_state(dev, drv, next_state); > > if (broadcast) > - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, > - &dev->cpu); > + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu); > > trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, dev->cpu); > >
On 26 September 2013 03:33, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > I splitted these lines because they have 81 cols. >> - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, >> - &dev->cpu); >> + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu); This one comes in 80 columns >> - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, >> - &dev->cpu); >> + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu); And this one in 79.. And so I did this change.. I have checked it again now..
On 09/26/2013 07:51 AM, Viresh Kumar wrote: > On 26 September 2013 03:33, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> I splitted these lines because they have 81 cols. > >>> - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, >>> - &dev->cpu); >>> + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu); > > This one comes in 80 columns > >>> - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, >>> - &dev->cpu); >>> + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu); > > And this one in 79.. > > And so I did this change.. I have checked it again now.. Well I have 81 with Vi and 80 with Emacs :) May be some tabs converted to spaces ... Anyway if it fits 80 cols then it is ok.
On 26 September 2013 13:25, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> Well I have 81 with Vi and 80 with Emacs :)
Hmm.. vim gave me 80 :) .. I am looking at bottom right corner where it gives:
148, 66-80 22%
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index ed67e3c..43d5836 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -145,8 +145,7 @@ int cpuidle_idle_call(void) broadcast = drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP; if (broadcast) - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, - &dev->cpu); + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu); if (cpuidle_state_is_coupled(dev, drv, next_state)) entered_state = cpuidle_enter_state_coupled(dev, drv, @@ -155,8 +154,7 @@ int cpuidle_idle_call(void) entered_state = cpuidle_enter_state(dev, drv, next_state); if (broadcast) - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, - &dev->cpu); + clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu); trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, dev->cpu);
Few statements in cpuidle_idle_call() are broken into multiple lines, whereas they can actually come in a single line. Convert those to single line. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpuidle/cpuidle.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)