| Message ID | 20200502125949.194032-1-aford173@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: defconfig: Enable some audio drivers on i.MX8M Mini | expand |
On Tue, May 19, 2020 at 8:03 PM Shawn Guo <shawnguo@kernel.org> wrote: > > On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote: > > The i.MX8M Mini has supports the MICFIL digital interface. > > It's a 16-bit audio signal from a PDM microphone bitstream. > > The driver is already in the kernel, but the node is missing. > > > > This patch adds the micfil node. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > index c63685ae80ee..d46e727fc362 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > @@ -339,6 +339,25 @@ sai6: sai@30060000 { > > status = "disabled"; > > }; > > > > + micfil: micfil@30080000 { > > Find a generic node name, audio-controller maybe? The SAI's nodes are called SAI@xxxx If that's a deal-breaker, I can push a V3. I didn't see anyone from the device tree side comment, and the device tree binding doc states 'micfil@xxxxxx' so I used what was documented in the fsl,micfil.txt adam > > Shawn > > > + compatible = "fsl,imx8mm-micfil"; > > + reg = <0x30080000 0x10000>; > > + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clk IMX8MM_CLK_PDM_IPG>, > > + <&clk IMX8MM_CLK_PDM_ROOT>, > > + <&clk IMX8MM_AUDIO_PLL1_OUT>, > > + <&clk IMX8MM_AUDIO_PLL2_OUT>, > > + <&clk IMX8MM_CLK_EXT3>; > > + clock-names = "ipg_clk", "ipg_clk_app", > > + "pll8k", "pll11k", "clkext3"; > > + dmas = <&sdma2 24 25 0x80000000>; > > + dma-names = "rx"; > > + status = "disabled"; > > + }; > > + > > gpio1: gpio@30200000 { > > compatible = "fsl,imx8mm-gpio", "fsl,imx35-gpio"; > > reg = <0x30200000 0x10000>; > > -- > > 2.25.1 > >
On Wed, Oct 28, 2020 at 07:10:37AM -0500, Adam Ford wrote: > On Tue, May 19, 2020 at 8:03 PM Shawn Guo <shawnguo@kernel.org> wrote: > > > > On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote: > > > The i.MX8M Mini has supports the MICFIL digital interface. > > > It's a 16-bit audio signal from a PDM microphone bitstream. > > > The driver is already in the kernel, but the node is missing. > > > > > > This patch adds the micfil node. > > > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > index c63685ae80ee..d46e727fc362 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > @@ -339,6 +339,25 @@ sai6: sai@30060000 { > > > status = "disabled"; > > > }; > > > > > > + micfil: micfil@30080000 { > > > > Find a generic node name, audio-controller maybe? > > The SAI's nodes are called SAI@xxxx > > If that's a deal-breaker, I can push a V3. > > I didn't see anyone from the device tree side comment, and the device > tree binding doc states 'micfil@xxxxxx' so I used what was documented > in the fsl,micfil.txt Hi, The example in the binding is not a binding itself. It can be misleading or even incorrect and it is not a reason to use such in DTS. Could be also audio-codec but it is not accurate (as it is only from the microphone to digital). Shawn's proposal is the best, I think. Best regards, Krzysztof
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 366857dfa9de..4e60e8a98b83 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -638,6 +638,8 @@ CONFIG_SND_HDA_TEGRA=m CONFIG_SND_HDA_CODEC_HDMI=m CONFIG_SND_SOC=y CONFIG_SND_BCM2835_SOC_I2S=m +CONFIG_SND_SOC_FSL_SAI=y +CONFIG_SND_SOC_FSL_MICFIL=y CONFIG_SND_MESON_AXG_SOUND_CARD=m CONFIG_SND_SOC_SDM845=m CONFIG_SND_SOC_ROCKCHIP=m
The i.MX8M Mini has SAI and micfil support but the drivers are not being loaded. This patch updates the defconfig to add support CONFIG_SND_SOC_FSL_SAI and CONFIG_SND_SOC_FSL_MICFIL to support these drivers. Signed-off-by: Adam Ford <aford173@gmail.com>