| Message ID | 20200612072901.14388-1-ludovic.barre@st.com |
|---|---|
| State | New |
| Headers | show |
| Series | irqchip/stm32: fix return value of stm32_exti_h_set_affinity | expand |
Hi Marc Just a gentleman ping about this patch. I verified, you could always apply this patch on linux master branch. Regards Ludo Le 6/12/20 à 9:29 AM, Ludovic Barre a écrit : > exti hardware point of view, there is no specific action on set_affinity. > So the affinity must be forwarded to parent if there is a > descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE. > > Signed-off-by: Ludovic Barre <ludovic.barre@st.com> > --- > drivers/irqchip/irq-stm32-exti.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c > index faa8482c8246..1a0a60ee7140 100644 > --- a/drivers/irqchip/irq-stm32-exti.c > +++ b/drivers/irqchip/irq-stm32-exti.c > @@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d, > if (d->parent_data->chip) > return irq_chip_set_affinity_parent(d, dest, force); > > - return -EINVAL; > + return IRQ_SET_MASK_OK_DONE; > } > > static int __maybe_unused stm32_exti_h_suspend(void) >
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index faa8482c8246..1a0a60ee7140 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d, if (d->parent_data->chip) return irq_chip_set_affinity_parent(d, dest, force); - return -EINVAL; + return IRQ_SET_MASK_OK_DONE; } static int __maybe_unused stm32_exti_h_suspend(void)
exti hardware point of view, there is no specific action on set_affinity. So the affinity must be forwarded to parent if there is a descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE. Signed-off-by: Ludovic Barre <ludovic.barre@st.com> --- drivers/irqchip/irq-stm32-exti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)