| Message ID | 20200630072822.26828-3-miquel.raynal@bootlin.com |
|---|---|
| State | Accepted |
| Commit | b440915af2e41daff7ee33e1d0ec29af5c37a1bf |
| Headers | show |
| Series | NAND ECC engine binding changes | expand |
On Tue, 30 Jun 2020 09:28:22 +0200, Miquel Raynal wrote: > Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. > The former is here to force software correction, the latter prevents > any correction to happen. > > These properties (along with nand-ecc-engine) are supposed to be more > accurate than the current nand-ecc-modes wich is very misleading and > very often people think it is mandatory while the core should be > relied upon to decide which correction to handle. > > nand-ecc-mode was already inacurate, but it becomes totally > problematic with setups where there are several hardware engines. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > .../devicetree/bindings/mtd/nand-controller.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml index 9ee0f3827047..d0238e9ba3f4 100644 --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml @@ -69,6 +69,14 @@ patternProperties: 3/ The ECC engine is external, in this case the phandle should reference the specific ECC engine node. + nand-use-soft-ecc-engine: + type: boolean + description: Use a software ECC engine. + + nand-no-ecc-engine: + type: boolean + description: Do not use any ECC correction. + nand-ecc-placement: allOf: - $ref: /schemas/types.yaml#/definitions/string
Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. The former is here to force software correction, the latter prevents any correction to happen. These properties (along with nand-ecc-engine) are supposed to be more accurate than the current nand-ecc-modes wich is very misleading and very often people think it is mandatory while the core should be relied upon to decide which correction to handle. nand-ecc-mode was already inacurate, but it becomes totally problematic with setups where there are several hardware engines. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- .../devicetree/bindings/mtd/nand-controller.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)