diff mbox series

[10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args

Message ID 20200625064619.2775707-11-lee.jones@linaro.org
State Accepted
Commit 0824c889e1a4b1ec0edf890689c7852363c4b055
Headers show
Series [01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args | expand

Commit Message

Lee Jones June 25, 2020, 6:46 a.m. UTC 
Kerneldoc syntax is used, but not complete.  Arg descriptions are required.

Fixes the following W=1 build warnings:

 drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'np' not described in 'altr_sysmgr_regmap_lookup_by_phandle'
 drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'property' not described in 'altr_sysmgr_regmap_lookup_by_phandle'

Cc: <stable@vger.kernel.org>
Cc: Thor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/mfd/altera-sysmgr.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.25.1

Comments

Sasha Levin July 1, 2020, 7:33 p.m. UTC | #1 
Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

v5.7.6: Build OK!
v5.4.49: Build OK!
v4.19.130: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.14.186: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.9.228: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
    d0f949e220fdf ("mfd: Add STM32 Timers driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.4.228: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    8ce064bfe7c8c ("MAINTAINERS: Add Altera Arria10 System Resource Chip")
    937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
    9787f5e28b507 ("mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip")
    b25c6b7d2801f ("mfd: act8945a: Add Active-semi ACT8945A PMIC MFD driver")
    d0f949e220fdf ("mfd: Add STM32 Timers driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha
Lee Jones July 2, 2020, 6:35 a.m. UTC | #2 
On Wed, 01 Jul 2020, Sasha Levin wrote:

> Hi

> 

> [This is an automated email]

> 

> This commit has been processed because it contains a -stable tag.

> The stable tag indicates that it's relevant for the following trees: all

> 

> The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

> 

> v5.7.6: Build OK!

> v5.4.49: Build OK!

> v4.19.130: Failed to apply! Possible dependencies:

>     51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")

>     f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

> 

> v4.14.186: Failed to apply! Possible dependencies:

>     51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")

>     f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

> 

> v4.9.228: Failed to apply! Possible dependencies:

>     51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")

>     937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")

>     d0f949e220fdf ("mfd: Add STM32 Timers driver")

>     f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

> 

> v4.4.228: Failed to apply! Possible dependencies:

>     51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")

>     8ce064bfe7c8c ("MAINTAINERS: Add Altera Arria10 System Resource Chip")

>     937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")

>     9787f5e28b507 ("mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip")

>     b25c6b7d2801f ("mfd: act8945a: Add Active-semi ACT8945A PMIC MFD driver")

>     d0f949e220fdf ("mfd: Add STM32 Timers driver")

>     f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

> 

> 

> NOTE: The patch will not be queued to stable trees until it is upstream.

> 

> How should we proceed with this patch?


Please drop it.

Greg indicated that these should not be bound for Stable.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Sasha Levin July 10, 2020, 2:02 p.m. UTC | #3 
Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

v5.7.6: Build OK!
v5.4.49: Build OK!
v4.19.130: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.14.186: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.9.228: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
    d0f949e220fdf ("mfd: Add STM32 Timers driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.4.228: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    8ce064bfe7c8c ("MAINTAINERS: Add Altera Arria10 System Resource Chip")
    937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
    9787f5e28b507 ("mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip")
    b25c6b7d2801f ("mfd: act8945a: Add Active-semi ACT8945A PMIC MFD driver")
    d0f949e220fdf ("mfd: Add STM32 Timers driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha
diff mbox series

Patch

diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c
index 83f0765f819b0..41076d121dd54 100644
--- a/drivers/mfd/altera-sysmgr.c
+++ b/drivers/mfd/altera-sysmgr.c
@@ -89,6 +89,9 @@  static struct regmap_config altr_sysmgr_regmap_cfg = {
  * altr_sysmgr_regmap_lookup_by_phandle
  * Find the sysmgr previous configured in probe() and return regmap property.
  * Return: regmap if found or error if not found.
+ *
+ * @np: Pointer to device's Device Tree node
+ * @property: Device Tree property name which references the sysmgr
  */
 struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np,
 						    const char *property)