diff mbox

Fix SEGV in JTReg test

Message ID 1376479407.30964.3.camel@fleetfoot.lan
State Accepted
Headers show

Commit Message

Edward Nevill Aug. 14, 2013, 11:23 a.m. UTC 
Hi,

Test7103261 in JTReg fails with a SEGV due to a missing implicit null
check.

The patch below fixes this.

OK?

Ed.

--- cut here ---
# HG changeset patch
# User Edward Nevill ed@camswl.com
# Date 1376479124 -3600
# Node ID 2fee62abab5d36bf37a16b43620f7834879b89f3
# Parent  ce185e10867844cdd00b4cd1b2c96c524a0706dc
Fix SEGV in JTReg Test7103261

Comments

Andrew Haley Aug. 14, 2013, 12:41 p.m. UTC | #1 
On 08/14/2013 12:23 PM, Edward Nevill wrote:
> Hi,
> 
> Test7103261 in JTReg fails with a SEGV due to a missing implicit null
> check.
> 
> The patch below fixes this.
> 
> OK?

OK.  I'd quibble that the formatting is a bit eccentric.  It's like
this in most pleases, although we're not quite consistent everywhere:

  if (info != NULL) {
    add_debug_info_for_null_check(null_check_here, info);
  }

Andrew.
diff mbox

Patch

diff -r ce185e108678 -r 2fee62abab5d src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp
--- a/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp	Tue Aug 13 17:15:41 2013 +0100
+++ b/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp	Wed Aug 14 12:18:44 2013 +0100
@@ -713,6 +713,7 @@ 
     ShouldNotReachHere();
   }
 
+  if (info) add_debug_info_for_null_check_here(info);
   (_masm->*insn)(zr, as_Address(to_addr, rscratch1));
 }
 
--- cut here ---