| Message ID | 20200106120558.37758-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Commit | 5aa0c467519ccd862678a15885026660c271b5b0 |
| Headers | show |
| Series | [next] power: avs: fix uninitialized error return on failed cpr_read_fuse_uV call | expand |
On Mon 06 Jan 04:05 PST 2020, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently when the call cpr_read_fuse_uV returns an error the value in the > uninitialized variable ret is returned. Fix this by instread returning the > error value in the variable uV. > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/power/avs/qcom-cpr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c > index 9247f53550b3..0321729431a5 100644 > --- a/drivers/power/avs/qcom-cpr.c > +++ b/drivers/power/avs/qcom-cpr.c > @@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv) > uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage, > step_volt, drv); > if (uV < 0) > - return ret; > + return uV; > > fuse->min_uV = fdata->min_uV; > fuse->max_uV = fdata->max_uV; > -- > 2.24.0 >
On Mon, Jan 6, 2020 at 8:15 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Mon 06 Jan 04:05 PST 2020, Colin King wrote: > > > From: Colin Ian King <colin.king@canonical.com> > > > > Currently when the call cpr_read_fuse_uV returns an error the value in the > > uninitialized variable ret is returned. Fix this by instread returning the > > error value in the variable uV. > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Applied, thanks! > > Addresses-Coverity: ("Uninitialized scalar variable") > > Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/power/avs/qcom-cpr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c > > index 9247f53550b3..0321729431a5 100644 > > --- a/drivers/power/avs/qcom-cpr.c > > +++ b/drivers/power/avs/qcom-cpr.c > > @@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv) > > uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage, > > step_volt, drv); > > if (uV < 0) > > - return ret; > > + return uV; > > > > fuse->min_uV = fdata->min_uV; > > fuse->max_uV = fdata->max_uV; > > --
diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c index 9247f53550b3..0321729431a5 100644 --- a/drivers/power/avs/qcom-cpr.c +++ b/drivers/power/avs/qcom-cpr.c @@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv) uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage, step_volt, drv); if (uV < 0) - return ret; + return uV; fuse->min_uV = fdata->min_uV; fuse->max_uV = fdata->max_uV;