diff mbox series

ipq806x: gcc: Added the enable regs and mask for PRNG

Message ID 20200313185406.10029-1-ansuelsmth@gmail.com
State New
Headers show
Series ipq806x: gcc: Added the enable regs and mask for PRNG | expand

Commit Message

Christian Marangi March 13, 2020, 6:54 p.m. UTC 
kernel got hanged while reading from /dev/hwrng at the
time of PRNG clock enable

Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
 drivers/clk/qcom/gcc-ipq806x.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stephen Boyd March 13, 2020, 8:30 p.m. UTC | #1 
Quoting Ansuel Smith (2020-03-13 11:54:06)
> kernel got hanged while reading from /dev/hwrng at the
> time of PRNG clock enable
> 
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>

Is Abhishek the author? Otherwise the tag chain here looks wrong.

> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

Is there some Fixes: tag we can get here too?

> ---
>  drivers/clk/qcom/gcc-ipq806x.c | 2 ++
>  1 file changed, 2 insertions(+)
>
Christian Marangi March 13, 2020, 9:20 p.m. UTC | #2 
> -----Messaggio originale-----
> Da: Stephen Boyd <sboyd@kernel.org>
> Inviato: venerdì 13 marzo 2020 21:30
> A: Ansuel Smith <ansuelsmth@gmail.com>; agross@kernel.org
> Cc: Ansuel Smith <ansuelsmth@gmail.com>; Abhishek Sahu
> <absahu@codeaurora.org>; Bjorn Andersson
> <bjorn.andersson@linaro.org>; Michael Turquette
> <mturquette@baylibre.com>; linux-arm-msm@vger.kernel.org; linux-
> clk@vger.kernel.org; linux-kernel@vger.kernel.org
> Oggetto: Re: [PATCH] ipq806x: gcc: Added the enable regs and mask for
> PRNG
> 
> Quoting Ansuel Smith (2020-03-13 11:54:06)
> > kernel got hanged while reading from /dev/hwrng at the
> > time of PRNG clock enable
> >
> > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> 
> Is Abhishek the author? Otherwise the tag chain here looks wrong.
> 

Yes Abhishek is the author.

> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> 
> Is there some Fixes: tag we can get here too?
> 

Think  I should put the commit that added the gcc. Right?

> > ---
> >  drivers/clk/qcom/gcc-ipq806x.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
Stephen Boyd March 14, 2020, 1:15 a.m. UTC | #3 
Quoting ansuelsmth@gmail.com (2020-03-13 14:20:36)
> 
> 
> > -----Messaggio originale-----
> > Da: Stephen Boyd <sboyd@kernel.org>
> > Inviato: venerdì 13 marzo 2020 21:30
> > A: Ansuel Smith <ansuelsmth@gmail.com>; agross@kernel.org
> > Cc: Ansuel Smith <ansuelsmth@gmail.com>; Abhishek Sahu
> > <absahu@codeaurora.org>; Bjorn Andersson
> > <bjorn.andersson@linaro.org>; Michael Turquette
> > <mturquette@baylibre.com>; linux-arm-msm@vger.kernel.org; linux-
> > clk@vger.kernel.org; linux-kernel@vger.kernel.org
> > Oggetto: Re: [PATCH] ipq806x: gcc: Added the enable regs and mask for
> > PRNG
> > 
> > Quoting Ansuel Smith (2020-03-13 11:54:06)
> > > kernel got hanged while reading from /dev/hwrng at the
> > > time of PRNG clock enable
> > >
> > > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> > 
> > Is Abhishek the author? Otherwise the tag chain here looks wrong.
> > 
> 
> Yes Abhishek is the author.
> 
> > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > 
> > Is there some Fixes: tag we can get here too?
> > 
> 
> Think  I should put the commit that added the gcc. Right?
> 

Yes.
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
index b0eee0903807..a8456e09c44d 100644
--- a/drivers/clk/qcom/gcc-ipq806x.c
+++ b/drivers/clk/qcom/gcc-ipq806x.c
@@ -1224,6 +1224,8 @@  static struct clk_rcg prng_src = {
 		.parent_map = gcc_pxo_pll8_map,
 	},
 	.clkr = {
+		.enable_reg = 0x2e80,
+		.enable_mask = BIT(11),
 		.hw.init = &(struct clk_init_data){
 			.name = "prng_src",
 			.parent_names = gcc_pxo_pll8,