| Message ID | 20200408213330.27665-2-stanimir.varbanov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] venus: core: Add missing mutex destroy | expand |
Hi Stanimir, On Thu, Apr 09, 2020 at 12:33:24AM +0300, Stanimir Varbanov wrote: > This adds missing mutex_destroy in remove method of venus core driver. > > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> > --- > drivers/media/platform/qcom/venus/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index 4395cb96fb04..f8b9a732bc65 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -335,6 +335,7 @@ static int venus_remove(struct platform_device *pdev) > > v4l2_device_unregister(&core->v4l2_dev); > mutex_destroy(&core->pm_lock); > + mutex_destroy(&core->lock); > > return ret; > } On which tree is this series based? From the context it seems that the tree includes the patch "venus: vdec: Use pmruntime autosuspend" (https://lore.kernel.org/patchwork/patch/1187829/), however I can not find this patch in any of the branches of your git tree (https://git.linuxtv.org/svarbanov/media_tree.git/) Am I looking in the wrong place?
Hi Matthias, On 4/10/20 12:47 AM, Matthias Kaehlcke wrote: > Hi Stanimir, > > On Thu, Apr 09, 2020 at 12:33:24AM +0300, Stanimir Varbanov wrote: >> This adds missing mutex_destroy in remove method of venus core driver. >> >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> >> --- >> drivers/media/platform/qcom/venus/core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c >> index 4395cb96fb04..f8b9a732bc65 100644 >> --- a/drivers/media/platform/qcom/venus/core.c >> +++ b/drivers/media/platform/qcom/venus/core.c >> @@ -335,6 +335,7 @@ static int venus_remove(struct platform_device *pdev) >> >> v4l2_device_unregister(&core->v4l2_dev); >> mutex_destroy(&core->pm_lock); >> + mutex_destroy(&core->lock); >> >> return ret; >> } > > On which tree is this series based? From the context it seems that the > tree includes the patch "venus: vdec: Use pmruntime autosuspend" > (https://lore.kernel.org/patchwork/patch/1187829/), however I can not > find this patch in any of the branches of your git tree > (https://git.linuxtv.org/svarbanov/media_tree.git/) Yes, sorry about that. It is based on runtime suspend patch and few others. I prepared a pull request but did not send it nor publish the branch yet cause I wait for rc1 tag. > > Am I looking in the wrong place? > No, you are on right place. I will update my linuxtv tree with material for v5.8.
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c index 4395cb96fb04..f8b9a732bc65 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -335,6 +335,7 @@ static int venus_remove(struct platform_device *pdev) v4l2_device_unregister(&core->v4l2_dev); mutex_destroy(&core->pm_lock); + mutex_destroy(&core->lock); return ret; }
This adds missing mutex_destroy in remove method of venus core driver. Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> --- drivers/media/platform/qcom/venus/core.c | 1 + 1 file changed, 1 insertion(+)