diff mbox series

[v1,05/14] configure: favour gdb-multiarch if we have it

Message ID 20200423170557.31106-6-alex.bennee@linaro.org
State Superseded
Headers show
Series guest_base, gdbstub and Travis | expand

Commit Message

Alex Bennée April 23, 2020, 5:05 p.m. UTC 
As gdb will generally be talking to "foreign" guests lets use that if
we can. Otherwise the chances of gdb barfing are considerably higher.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé April 23, 2020, 8:28 p.m. UTC | #1 
On 4/23/20 7:05 PM, Alex Bennée wrote:
> As gdb will generally be talking to "foreign" guests lets use that if

> we can. Otherwise the chances of gdb barfing are considerably higher.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   configure | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/configure b/configure

> index 23b5e93752..c58787100f 100755

> --- a/configure

> +++ b/configure

> @@ -303,7 +303,7 @@ libs_qga=""

>   debug_info="yes"

>   stack_protector=""

>   use_containers="yes"

> -gdb_bin=$(command -v "gdb")

> +gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb")

>   


Good one!

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


>   if test -e "$source_path/.git"

>   then

>
diff mbox series

Patch

diff --git a/configure b/configure
index 23b5e93752..c58787100f 100755
--- a/configure
+++ b/configure
@@ -303,7 +303,7 @@  libs_qga=""
 debug_info="yes"
 stack_protector=""
 use_containers="yes"
-gdb_bin=$(command -v "gdb")
+gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb")
 
 if test -e "$source_path/.git"
 then