| Message ID | 1374641005-14662-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
> -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Wednesday, July 24, 2013 1:43 PM > To: dri-devel@lists.freedesktop.org > Cc: inki.dae@samsung.com; jy0922.shim@samsung.com; sachin.kamat@linaro.org; > patches@linaro.org > Subject: [PATCH 1/1] drm/exynos: Remove module.h header inclusion > > Since Exynos DRM drivers do not support module build, > remove module.h header file inclusion from files that do > not have any users. Not true, and supported. Actually, we are using Exynos drm driver as a module on our target, and that works fine. Seem like your misunderstanding to my previous patch, fix module build error. Thanks, Inki Dae > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/gpu/drm/exynos/exynos_ddc.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 1 - > drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - > drivers/gpu/drm/exynos/exynos_hdmiphy.c | 1 - > drivers/gpu/drm/exynos/exynos_mixer.c | 1 - > 12 files changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_ddc.c > b/drivers/gpu/drm/exynos/exynos_ddc.c > index 95c75ed..30ef41b 100644 > --- a/drivers/gpu/drm/exynos/exynos_ddc.c > +++ b/drivers/gpu/drm/exynos/exynos_ddc.c > @@ -15,7 +15,6 @@ > > #include <linux/kernel.h> > #include <linux/i2c.h> > -#include <linux/module.h> > > > #include "exynos_drm_drv.h" > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c > b/drivers/gpu/drm/exynos/exynos_drm_fimc.c > index 61b094f..6e047bd 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c > @@ -12,7 +12,6 @@ > * > */ > #include <linux/kernel.h> > -#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/mfd/syscon.h> > #include <linux/regmap.h> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 5dba79e..1c263da 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -14,7 +14,6 @@ > #include <drm/drmP.h> > > #include <linux/kernel.h> > -#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/clk.h> > #include <linux/of_device.h> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > index 4722662..df0a0d6 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -8,7 +8,6 @@ > */ > > #include <linux/kernel.h> > -#include <linux/module.h> > #include <linux/clk.h> > #include <linux/err.h> > #include <linux/interrupt.h> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c > b/drivers/gpu/drm/exynos/exynos_drm_gsc.c > index 472e3b2..90b8a1a 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c > @@ -12,7 +12,6 @@ > * > */ > #include <linux/kernel.h> > -#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/clk.h> > #include <linux/pm_runtime.h> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c > b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c > index aaa550d..8d3bc01 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c > @@ -15,7 +15,6 @@ > > #include <linux/kernel.h> > #include <linux/wait.h> > -#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/pm_runtime.h> > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c > b/drivers/gpu/drm/exynos/exynos_drm_ipp.c > index 0eb8538..d2b6ab4 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c > @@ -12,7 +12,6 @@ > * > */ > #include <linux/kernel.h> > -#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/types.h> > #include <linux/clk.h> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c > b/drivers/gpu/drm/exynos/exynos_drm_rotator.c > index 427640a..49669aa 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c > @@ -10,7 +10,6 @@ > */ > > #include <linux/kernel.h> > -#include <linux/module.h> > #include <linux/err.h> > #include <linux/interrupt.h> > #include <linux/io.h> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c > b/drivers/gpu/drm/exynos/exynos_drm_vidi.c > index 41cc74d..c57c565 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c > @@ -13,7 +13,6 @@ > #include <drm/drmP.h> > > #include <linux/kernel.h> > -#include <linux/module.h> > #include <linux/platform_device.h> > > #include <drm/exynos_drm.h> > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c > b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 62ef597..2f5c694 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -24,7 +24,6 @@ > #include <linux/spinlock.h> > #include <linux/wait.h> > #include <linux/i2c.h> > -#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/interrupt.h> > #include <linux/irq.h> > diff --git a/drivers/gpu/drm/exynos/exynos_hdmiphy.c > b/drivers/gpu/drm/exynos/exynos_hdmiphy.c > index ef04255..6e320ae 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmiphy.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmiphy.c > @@ -15,7 +15,6 @@ > > #include <linux/kernel.h> > #include <linux/i2c.h> > -#include <linux/module.h> > > #include "exynos_drm_drv.h" > #include "exynos_hdmi.h" > diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c > b/drivers/gpu/drm/exynos/exynos_mixer.c > index 42ffb71..c9a137c 100644 > --- a/drivers/gpu/drm/exynos/exynos_mixer.c > +++ b/drivers/gpu/drm/exynos/exynos_mixer.c > @@ -23,7 +23,6 @@ > #include <linux/spinlock.h> > #include <linux/wait.h> > #include <linux/i2c.h> > -#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/interrupt.h> > #include <linux/irq.h> > -- > 1.7.9.5
On 26 July 2013 07:00, Inki Dae <inki.dae@samsung.com> wrote: > > >> -----Original Message----- >> From: Sachin Kamat [mailto:sachin.kamat@linaro.org] >> Sent: Wednesday, July 24, 2013 1:43 PM >> To: dri-devel@lists.freedesktop.org >> Cc: inki.dae@samsung.com; jy0922.shim@samsung.com; > sachin.kamat@linaro.org; >> patches@linaro.org >> Subject: [PATCH 1/1] drm/exynos: Remove module.h header inclusion >> >> Since Exynos DRM drivers do not support module build, >> remove module.h header file inclusion from files that do >> not have any users. > > Not true, and supported. Actually, we are using Exynos drm driver as a > module on our target, and that works fine. Seem like your misunderstanding > to my previous patch, fix module build error. May be my description was not clear. However the header files are still not required as these files do not access anything provided in module.h (after removal of MODULE_DEVICE_TABLE).
> -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Friday, July 26, 2013 11:51 AM > To: Inki Dae > Cc: dri-devel@lists.freedesktop.org; jy0922.shim@samsung.com; > patches@linaro.org > Subject: Re: [PATCH 1/1] drm/exynos: Remove module.h header inclusion > > On 26 July 2013 07:00, Inki Dae <inki.dae@samsung.com> wrote: > > > > > >> -----Original Message----- > >> From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > >> Sent: Wednesday, July 24, 2013 1:43 PM > >> To: dri-devel@lists.freedesktop.org > >> Cc: inki.dae@samsung.com; jy0922.shim@samsung.com; > > sachin.kamat@linaro.org; > >> patches@linaro.org > >> Subject: [PATCH 1/1] drm/exynos: Remove module.h header inclusion > >> > >> Since Exynos DRM drivers do not support module build, > >> remove module.h header file inclusion from files that do > >> not have any users. > > > > Not true, and supported. Actually, we are using Exynos drm driver as a > > module on our target, and that works fine. Seem like your > misunderstanding > > to my previous patch, fix module build error. > > May be my description was not clear. However the header files are > still not required as these files do not access anything provided in > module.h (after removal of MODULE_DEVICE_TABLE). > Right, please repost it with correct description. Thanks, Inki Dae > > -- > With warm regards, > Sachin
On 26 July 2013 12:51, Inki Dae <inki.dae@samsung.com> wrote: > > >> -----Original Message----- >> From: Sachin Kamat [mailto:sachin.kamat@linaro.org] >> Sent: Friday, July 26, 2013 11:51 AM >> To: Inki Dae >> Cc: dri-devel@lists.freedesktop.org; jy0922.shim@samsung.com; >> patches@linaro.org >> Subject: Re: [PATCH 1/1] drm/exynos: Remove module.h header inclusion >> >> On 26 July 2013 07:00, Inki Dae <inki.dae@samsung.com> wrote: >> > >> > >> >> -----Original Message----- >> >> From: Sachin Kamat [mailto:sachin.kamat@linaro.org] >> >> Sent: Wednesday, July 24, 2013 1:43 PM >> >> To: dri-devel@lists.freedesktop.org >> >> Cc: inki.dae@samsung.com; jy0922.shim@samsung.com; >> > sachin.kamat@linaro.org; >> >> patches@linaro.org >> >> Subject: [PATCH 1/1] drm/exynos: Remove module.h header inclusion >> >> >> >> Since Exynos DRM drivers do not support module build, >> >> remove module.h header file inclusion from files that do >> >> not have any users. >> > >> > Not true, and supported. Actually, we are using Exynos drm driver as a >> > module on our target, and that works fine. Seem like your >> misunderstanding >> > to my previous patch, fix module build error. >> >> May be my description was not clear. However the header files are >> still not required as these files do not access anything provided in >> module.h (after removal of MODULE_DEVICE_TABLE). >> > > Right, please repost it with correct description. Done.
diff --git a/drivers/gpu/drm/exynos/exynos_ddc.c b/drivers/gpu/drm/exynos/exynos_ddc.c index 95c75ed..30ef41b 100644 --- a/drivers/gpu/drm/exynos/exynos_ddc.c +++ b/drivers/gpu/drm/exynos/exynos_ddc.c @@ -15,7 +15,6 @@ #include <linux/kernel.h> #include <linux/i2c.h> -#include <linux/module.h> #include "exynos_drm_drv.h" diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 61b094f..6e047bd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -12,7 +12,6 @@ * */ #include <linux/kernel.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/mfd/syscon.h> #include <linux/regmap.h> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 5dba79e..1c263da 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -14,7 +14,6 @@ #include <drm/drmP.h> #include <linux/kernel.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/clk.h> #include <linux/of_device.h> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 4722662..df0a0d6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -8,7 +8,6 @@ */ #include <linux/kernel.h> -#include <linux/module.h> #include <linux/clk.h> #include <linux/err.h> #include <linux/interrupt.h> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index 472e3b2..90b8a1a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -12,7 +12,6 @@ * */ #include <linux/kernel.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/clk.h> #include <linux/pm_runtime.h> diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c index aaa550d..8d3bc01 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c @@ -15,7 +15,6 @@ #include <linux/kernel.h> #include <linux/wait.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index 0eb8538..d2b6ab4 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c @@ -12,7 +12,6 @@ * */ #include <linux/kernel.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/types.h> #include <linux/clk.h> diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c index 427640a..49669aa 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c @@ -10,7 +10,6 @@ */ #include <linux/kernel.h> -#include <linux/module.h> #include <linux/err.h> #include <linux/interrupt.h> #include <linux/io.h> diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index 41cc74d..c57c565 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -13,7 +13,6 @@ #include <drm/drmP.h> #include <linux/kernel.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <drm/exynos_drm.h> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 62ef597..2f5c694 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -24,7 +24,6 @@ #include <linux/spinlock.h> #include <linux/wait.h> #include <linux/i2c.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/interrupt.h> #include <linux/irq.h> diff --git a/drivers/gpu/drm/exynos/exynos_hdmiphy.c b/drivers/gpu/drm/exynos/exynos_hdmiphy.c index ef04255..6e320ae 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmiphy.c +++ b/drivers/gpu/drm/exynos/exynos_hdmiphy.c @@ -15,7 +15,6 @@ #include <linux/kernel.h> #include <linux/i2c.h> -#include <linux/module.h> #include "exynos_drm_drv.h" #include "exynos_hdmi.h" diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index 42ffb71..c9a137c 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -23,7 +23,6 @@ #include <linux/spinlock.h> #include <linux/wait.h> #include <linux/i2c.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/interrupt.h> #include <linux/irq.h>
Since Exynos DRM drivers do not support module build, remove module.h header file inclusion from files that do not have any users. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/gpu/drm/exynos/exynos_ddc.c | 1 - drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 - drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 - drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 - drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 1 - drivers/gpu/drm/exynos/exynos_drm_ipp.c | 1 - drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 - drivers/gpu/drm/exynos/exynos_drm_vidi.c | 1 - drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - drivers/gpu/drm/exynos/exynos_hdmiphy.c | 1 - drivers/gpu/drm/exynos/exynos_mixer.c | 1 - 12 files changed, 12 deletions(-)