diff mbox series

[1/1] HID: hiddev: remove a duplicated check

Message ID 20191224035117.98816-1-thunder.leizhen@huawei.com
State New
Headers show
Series [1/1] HID: hiddev: remove a duplicated check | expand

Commit Message

Leizhen (ThunderTown) Dec. 24, 2019, 3:51 a.m. UTC 
After commit 9c09b214f30e ("HID: hiddev: avoid opening a disconnected
device"), the original check "list->hiddev->exist" become unnecessary.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

---
 drivers/hid/usbhid/hiddev.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

-- 
1.8.3
diff mbox series

Patch

diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index e421cdf2d1a4ec5..e04cf95fca094a8 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -292,16 +292,16 @@  static int hiddev_open(struct inode *inode, struct file *file)
 		res = -ENODEV;
 		goto bail_unlock;
 	}
-	if (!list->hiddev->open++)
-		if (list->hiddev->exist) {
-			struct hid_device *hid = hiddev->hid;
-			res = hid_hw_power(hid, PM_HINT_FULLON);
-			if (res < 0)
-				goto bail_unlock;
-			res = hid_hw_open(hid);
-			if (res < 0)
-				goto bail_normal_power;
-		}
+	if (!list->hiddev->open++) {
+		struct hid_device *hid = hiddev->hid;
+
+		res = hid_hw_power(hid, PM_HINT_FULLON);
+		if (res < 0)
+			goto bail_unlock;
+		res = hid_hw_open(hid);
+		if (res < 0)
+			goto bail_normal_power;
+	}
 	mutex_unlock(&hiddev->existancelock);
 	return 0;
 bail_normal_power: