| Message ID | df20147329f4f1521107d20da92559a187494b04.1573443694.git.baolin.wang@linaro.org |
|---|---|
| State | Accepted |
| Commit | 9629dbdabd1983ef53f125336e1d62d77b1620f9 |
| Headers | show |
| Series | [RESEND,v2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() | expand |
diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c index 3718696..c0af477 100644 --- a/drivers/clk/sprd/common.c +++ b/drivers/clk/sprd/common.c @@ -45,7 +45,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev, if (of_find_property(node, "sprd,syscon", NULL)) { regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon"); - if (IS_ERR_OR_NULL(regmap)) { + if (IS_ERR(regmap)) { pr_err("%s: failed to get syscon regmap\n", __func__); return PTR_ERR(regmap); }
The syscon_regmap_lookup_by_phandle() will never return NULL, thus use IS_ERR() to validate the return value instead of IS_ERR_OR_NULL(). Fixes: d41f59fd92f2 ("clk: sprd: Add common infrastructure") Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- Changes from v1: - Add fixes tag. --- drivers/clk/sprd/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.7.9.5