| Message ID | 20191022191704.6134-8-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing/next before softfreeze | expand |
----- Original Message ----- > From: "Alex Bennée" <alex.bennee@linaro.org> > Sent: Tuesday, October 22, 2019 9:16:52 PM > > The MacOS build can time out on Cirrus running to almost an hour. > Reduce the scope to the historical MacOS architectures much the same > way we do on Travis. Oh, really? For me, the builds on Cirrus-CI work reasonable fast and almost always finish within 20 minutes, e.g.: https://cirrus-ci.com/build/4976412120842240 Also the last macos_task from the official QEMU mirror on github finished within 15 minutes: https://github.com/qemu/qemu/runs/269964092 ... so was your issue maybe just a temporary dropout? Thomas
Thomas Huth <thuth@redhat.com> writes: > ----- Original Message ----- >> From: "Alex Bennée" <alex.bennee@linaro.org> >> Sent: Tuesday, October 22, 2019 9:16:52 PM >> >> The MacOS build can time out on Cirrus running to almost an hour. >> Reduce the scope to the historical MacOS architectures much the same >> way we do on Travis. > > Oh, really? For me, the builds on Cirrus-CI work reasonable fast and > almost always finish within 20 minutes, e.g.: It seems to be an intermittent thing: https://cirrus-ci.com/github/stsquad/qemu but looking again maybe it's only the xcode build that is reliably long... > > https://cirrus-ci.com/build/4976412120842240 > > Also the last macos_task from the official QEMU mirror on github finished within 15 minutes: > > https://github.com/qemu/qemu/runs/269964092 > > ... so was your issue maybe just a temporary dropout? > > Thomas -- Alex Bennée
Alex Bennée <alex.bennee@linaro.org> writes: > Thomas Huth <thuth@redhat.com> writes: > >> ----- Original Message ----- >>> From: "Alex Bennée" <alex.bennee@linaro.org> >>> Sent: Tuesday, October 22, 2019 9:16:52 PM >>> >>> The MacOS build can time out on Cirrus running to almost an hour. >>> Reduce the scope to the historical MacOS architectures much the same >>> way we do on Travis. >> >> Oh, really? For me, the builds on Cirrus-CI work reasonable fast and >> almost always finish within 20 minutes, e.g.: > > It seems to be an intermittent thing: > > https://cirrus-ci.com/github/stsquad/qemu > > but looking again maybe it's only the xcode build that is reliably > long... So the MacOS build failed: https://cirrus-ci.com/task/5574076248096768 I think the MacOS builds just occasionally get stuck for some reason. > >> >> https://cirrus-ci.com/build/4976412120842240 >> >> Also the last macos_task from the official QEMU mirror on github finished within 15 minutes: >> >> https://github.com/qemu/qemu/runs/269964092 >> >> ... so was your issue maybe just a temporary dropout? >> >> Thomas -- Alex Bennée
On Tue, 22 Oct 2019 at 20:20, Alex Bennée <alex.bennee@linaro.org> wrote: > > The MacOS build can time out on Cirrus running to almost an hour. > Reduce the scope to the historical MacOS architectures much the same > way we do on Travis. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .cirrus.yml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.cirrus.yml b/.cirrus.yml > index 8326a3a4b16..4b042c0e12c 100644 > --- a/.cirrus.yml > +++ b/.cirrus.yml > @@ -1,5 +1,6 @@ > env: > CIRRUS_CLONE_DEPTH: 1 > + MACOS_ARCHES: i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu I don't know whether Cirrus is our long-term plan for doing CI of OSX (maybe we'll be using Gitlab and some runner on an OSX platform??), but as a general point: since OSX is one of the non-Linux hosts it's therefore worth making sure our compile-coverage is as wide as possible, not narrow. It's safe(r) to have narrow coverage of x86-Linux because people catch issues with that anyway, but it's exactly the less common platforms like OSX, the BSDs, odd architectures that we want to be compile/make-check testing as much of our code as possible. thanks -- PMM
On 24/10/19 11:02, Peter Maydell wrote: >> --- a/.cirrus.yml >> +++ b/.cirrus.yml >> @@ -1,5 +1,6 @@ >> env: >> CIRRUS_CLONE_DEPTH: 1 >> + MACOS_ARCHES: i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu > I don't know whether Cirrus is our long-term plan for doing > CI of OSX (maybe we'll be using Gitlab and some runner on an > OSX platform??), My plan was to deploy Patchew on a Macincloud instance. Paolo but as a general point: since OSX is one of > the non-Linux hosts it's therefore worth making sure our > compile-coverage is as wide as possible, not narrow. It's > safe(r) to have narrow coverage of x86-Linux because people > catch issues with that anyway, but it's exactly the less > common platforms like OSX, the BSDs, odd architectures that > we want to be compile/make-check testing as much of our code > as possible.
Peter Maydell <peter.maydell@linaro.org> writes: > On Tue, 22 Oct 2019 at 20:20, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> The MacOS build can time out on Cirrus running to almost an hour. >> Reduce the scope to the historical MacOS architectures much the same >> way we do on Travis. >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> .cirrus.yml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/.cirrus.yml b/.cirrus.yml >> index 8326a3a4b16..4b042c0e12c 100644 >> --- a/.cirrus.yml >> +++ b/.cirrus.yml >> @@ -1,5 +1,6 @@ >> env: >> CIRRUS_CLONE_DEPTH: 1 >> + MACOS_ARCHES: i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu > > I don't know whether Cirrus is our long-term plan for doing > CI of OSX (maybe we'll be using Gitlab and some runner on an > OSX platform??), but as a general point: since OSX is one of > the non-Linux hosts it's therefore worth making sure our > compile-coverage is as wide as possible, not narrow. It's > safe(r) to have narrow coverage of x86-Linux because people > catch issues with that anyway, but it's exactly the less > common platforms like OSX, the BSDs, odd architectures that > we want to be compile/make-check testing as much of our code > as possible. OK I can drop the patch. It seems the long builds are just a random pause that occasionally happens on their MacOS host. > > thanks > -- PMM -- Alex Bennée
diff --git a/.cirrus.yml b/.cirrus.yml index 8326a3a4b16..4b042c0e12c 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -1,5 +1,6 @@ env: CIRRUS_CLONE_DEPTH: 1 + MACOS_ARCHES: i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu freebsd_12_task: freebsd_instance: @@ -22,6 +23,6 @@ macos_task: install_script: - brew install pkg-config python gnu-sed glib pixman make sdl2 script: - - ./configure --python=/usr/local/bin/python3 || { cat config.log; exit 1; } + - ./configure --python=/usr/local/bin/python3 --target-list=${MACOS_ARCHES} || { cat config.log; exit 1; } - gmake -j$(sysctl -n hw.ncpu) - gmake check -j$(sysctl -n hw.ncpu)
The MacOS build can time out on Cirrus running to almost an hour. Reduce the scope to the historical MacOS architectures much the same way we do on Travis. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.20.1