| Message ID | 20191018043148.6285-1-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | a31ec048ef01a76ff893e0fa482e569d04d0c4b4 |
| Headers | show |
| Series | [1/2] asm-generic/export.h: make __ksymtab_* local symbols | expand |
On Fri, Oct 18, 2019 at 2:03 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > For EXPORT_SYMBOL from C files, <linux/export.h> defines __ksymtab_* > as local symbols. > > For EXPORT_SYMBOL from assembly, in contrast, <asm-generic/export.h> > produces globally-visible __ksymtab_* symbols due to this .globl > directive. > > I do not understand why this must be global. It still works without > this .globl directive. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- I did not get objection, at least. Applied to linux-kbuild. > > include/asm-generic/export.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h > index fa577978fbbd..80ef2dc0c8be 100644 > --- a/include/asm-generic/export.h > +++ b/include/asm-generic/export.h > @@ -31,7 +31,6 @@ > */ > .macro ___EXPORT_SYMBOL name,val,sec > #ifdef CONFIG_MODULES > - .globl __ksymtab_\name > .section ___ksymtab\sec+\name,"a" > .balign KSYM_ALIGN > __ksymtab_\name: > -- > 2.17.1 > -- Best Regards Masahiro Yamada
diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h index fa577978fbbd..80ef2dc0c8be 100644 --- a/include/asm-generic/export.h +++ b/include/asm-generic/export.h @@ -31,7 +31,6 @@ */ .macro ___EXPORT_SYMBOL name,val,sec #ifdef CONFIG_MODULES - .globl __ksymtab_\name .section ___ksymtab\sec+\name,"a" .balign KSYM_ALIGN __ksymtab_\name:
For EXPORT_SYMBOL from C files, <linux/export.h> defines __ksymtab_* as local symbols. For EXPORT_SYMBOL from assembly, in contrast, <asm-generic/export.h> produces globally-visible __ksymtab_* symbols due to this .globl directive. I do not understand why this must be global. It still works without this .globl directive. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- include/asm-generic/export.h | 1 - 1 file changed, 1 deletion(-) -- 2.17.1