diff mbox

[1/3] ARM: dts: exynos4210: Add LCD related pinctrl entries

Message ID 1370603235-11193-2-git-send-email-tushar.behera@linaro.org
State Accepted
Headers show

Commit Message

Tushar Behera June 7, 2013, 11:07 a.m. UTC 
From: Sachin Kamat <sachin.kamat@linaro.org>

Adds pinctrl entries required by FIMD.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/boot/dts/exynos4210-pinctrl.dtsi |   75 +++++++++++++++++++++++++++++
 1 file changed, 75 insertions(+)

Comments

Tomasz Figa June 8, 2013, 10:46 a.m. UTC | #1 
Hi Tushar, Sachin,

On Friday 07 of June 2013 16:37:13 Tushar Behera wrote:
> From: Sachin Kamat <sachin.kamat@linaro.org>
> 
> Adds pinctrl entries required by FIMD.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4210-pinctrl.dtsi |   75
> +++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index 55a2efb..d241726
> 100644
> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> @@ -330,6 +330,81 @@
>  			samsung,pin-pud = <3>;
>  			samsung,pin-drv = <0>;
>  		};
> +
> +		pwm0_out: pwm0-out {
> +			samsung,pins = "gpd0-0";
> +			samsung,pin-function = <2>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		pwm1_out: pwm1-out {
> +			samsung,pins = "gpd0-1";
> +			samsung,pin-function = <2>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};

Hmm, these two seem to be unrelated. Rebase error? :)

> +		lcd_ctrl: lcd-ctrl {
> +			samsung,pins = "gpd0-0", "gpd0-1";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		lcd_sync: lcd-sync {
> +			samsung,pins = "gpf0-0", "gpf0-1";
> +			samsung,pin-function = <2>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		lcd_en: lcd-en {
> +			samsung,pins = "gpe3-4";
> +			samsung,pin-function = <2>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		lcd_clk: lcd-clk {
> +			samsung,pins = "gpf0-0", "gpf0-1", "gpf0-2", 
"gpf0-3";
> +			samsung,pin-function = <2>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		lcd_data16: lcd-data-width16 {
> +			samsung,pins = "gpf0-7", "gpf1-0", "gpf1-1", 
"gpf1-2",
> +					"gpf1-3", "gpf1-6", "gpf1-7", 
"gpf2-0",
> +					"gpf2-1", "gpf2-2", "gpf2-3", 
"gpf2-7",
> +					"gpf3-0", "gpf3-1", "gpf3-2", 
"gpf3-3";
> +			samsung,pin-function = <2>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		lcd_data18: lcd-data-width18 {
> +			samsung,pins = "gpf0-6", "gpf0-7", "gpf1-0", 
"gpf1-1",
> +					"gpf1-2", "gpf1-3", "gpf1-6", 
"gpf1-7",
> +					"gpf2-0", "gpf2-1", "gpf2-2", 
"gpf2-3",
> +					"gpf2-6", "gpf2-7", "gpf3-0", 
"gpf3-1",
> +					"gpf3-2", "gpf3-3";
> +			samsung,pin-function = <2>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
> +
> +		lcd_data24: lcd-data-width24 {
> +			samsung,pins = "gpf0-4", "gpf0-5", "gpf0-6", 
"gpf0-7",
> +					"gpf1-0", "gpf1-1", "gpf1-2", 
"gpf1-3",
> +					"gpf1-4", "gpf1-5", "gpf1-6", 
"gpf1-7",
> +					"gpf2-0", "gpf2-1", "gpf2-2", 
"gpf2-3",
> +					"gpf2-4", "gpf2-5", "gpf2-6", 
"gpf2-7",
> +					"gpf3-0", "gpf3-1", "gpf3-2", 
"gpf3-3";
> +			samsung,pin-function = <2>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
>  	};
> 
>  	pinctrl@11000000 {

Otherwise looks good to me.

Best regards,
Tomasz
Tushar Behera June 10, 2013, 4:10 a.m. UTC | #2 
On 06/08/2013 04:16 PM, Tomasz Figa wrote:
> Hi Tushar, Sachin,
> 
> On Friday 07 of June 2013 16:37:13 Tushar Behera wrote:
>> From: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Adds pinctrl entries required by FIMD.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>>  arch/arm/boot/dts/exynos4210-pinctrl.dtsi |   75
>> +++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index 55a2efb..d241726
>> 100644
>> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>> @@ -330,6 +330,81 @@
>>  			samsung,pin-pud = <3>;
>>  			samsung,pin-drv = <0>;
>>  		};
>> +
>> +		pwm0_out: pwm0-out {
>> +			samsung,pins = "gpd0-0";
>> +			samsung,pin-function = <2>;
>> +			samsung,pin-pud = <0>;
>> +			samsung,pin-drv = <0>;
>> +		};
>> +
>> +		pwm1_out: pwm1-out {
>> +			samsung,pins = "gpd0-1";
>> +			samsung,pin-function = <2>;
>> +			samsung,pin-pud = <0>;
>> +			samsung,pin-drv = <0>;
>> +		};
> 
> Hmm, these two seem to be unrelated. Rebase error? :)
> 

Not a rebase error. pwm0_out needs to configured to get display on LCD.
Tomasz Figa June 10, 2013, 6:30 p.m. UTC | #3 
On Monday 10 of June 2013 09:40:43 Tushar Behera wrote:
> On 06/08/2013 04:16 PM, Tomasz Figa wrote:
> > Hi Tushar, Sachin,
> > 
> > On Friday 07 of June 2013 16:37:13 Tushar Behera wrote:
> >> From: Sachin Kamat <sachin.kamat@linaro.org>
> >> 
> >> Adds pinctrl entries required by FIMD.
> >> 
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> >> ---
> >> 
> >>  arch/arm/boot/dts/exynos4210-pinctrl.dtsi |   75
> >> 
> >> +++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+)
> >> 
> >> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> >> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index 55a2efb..d241726
> >> 100644
> >> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> >> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> >> @@ -330,6 +330,81 @@
> >> 
> >>  			samsung,pin-pud = <3>;
> >>  			samsung,pin-drv = <0>;
> >>  		
> >>  		};
> >> 
> >> +
> >> +		pwm0_out: pwm0-out {
> >> +			samsung,pins = "gpd0-0";
> >> +			samsung,pin-function = <2>;
> >> +			samsung,pin-pud = <0>;
> >> +			samsung,pin-drv = <0>;
> >> +		};
> >> +
> >> +		pwm1_out: pwm1-out {
> >> +			samsung,pins = "gpd0-1";
> >> +			samsung,pin-function = <2>;
> >> +			samsung,pin-pud = <0>;
> >> +			samsung,pin-drv = <0>;
> >> +		};
> > 
> > Hmm, these two seem to be unrelated. Rebase error? :)
> 
> Not a rebase error. pwm0_out needs to configured to get display on LCD.

Please split this into two separate patches than, one adding LCD pin 
configuration nodes and one adding PWM pin configuration nodes.

Also I think it would be better to just define all available PWM outputs 
not only first two. if you are already at adding PWM pin configurations.

Thanks,
Tomasz
Tushar Behera June 11, 2013, 6:32 a.m. UTC | #4 
On 06/11/2013 12:00 AM, Tomasz Figa wrote:
> On Monday 10 of June 2013 09:40:43 Tushar Behera wrote:
>> On 06/08/2013 04:16 PM, Tomasz Figa wrote:
>>> Hi Tushar, Sachin,
>>>
>>> On Friday 07 of June 2013 16:37:13 Tushar Behera wrote:
>>>> From: Sachin Kamat <sachin.kamat@linaro.org>
>>>>
>>>> Adds pinctrl entries required by FIMD.
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>> ---
>>>>
>>>>  arch/arm/boot/dts/exynos4210-pinctrl.dtsi |   75
>>>>
>>>> +++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>>>> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index 55a2efb..d241726
>>>> 100644
>>>> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>>>> @@ -330,6 +330,81 @@
>>>>
>>>>  			samsung,pin-pud = <3>;
>>>>  			samsung,pin-drv = <0>;
>>>>  		
>>>>  		};
>>>>
>>>> +
>>>> +		pwm0_out: pwm0-out {
>>>> +			samsung,pins = "gpd0-0";
>>>> +			samsung,pin-function = <2>;
>>>> +			samsung,pin-pud = <0>;
>>>> +			samsung,pin-drv = <0>;
>>>> +		};
>>>> +
>>>> +		pwm1_out: pwm1-out {
>>>> +			samsung,pins = "gpd0-1";
>>>> +			samsung,pin-function = <2>;
>>>> +			samsung,pin-pud = <0>;
>>>> +			samsung,pin-drv = <0>;
>>>> +		};
>>>
>>> Hmm, these two seem to be unrelated. Rebase error? :)
>>
>> Not a rebase error. pwm0_out needs to configured to get display on LCD.
> 
> Please split this into two separate patches than, one adding LCD pin 
> configuration nodes and one adding PWM pin configuration nodes.
> 
> Also I think it would be better to just define all available PWM outputs 
> not only first two. if you are already at adding PWM pin configurations.
> 

Sure.

> Thanks,
> Tomasz
> 

Thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
index 55a2efb..d241726 100644
--- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
@@ -330,6 +330,81 @@ 
 			samsung,pin-pud = <3>;
 			samsung,pin-drv = <0>;
 		};
+
+		pwm0_out: pwm0-out {
+			samsung,pins = "gpd0-0";
+			samsung,pin-function = <2>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
+
+		pwm1_out: pwm1-out {
+			samsung,pins = "gpd0-1";
+			samsung,pin-function = <2>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
+
+		lcd_ctrl: lcd-ctrl {
+			samsung,pins = "gpd0-0", "gpd0-1";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
+
+		lcd_sync: lcd-sync {
+			samsung,pins = "gpf0-0", "gpf0-1";
+			samsung,pin-function = <2>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
+
+		lcd_en: lcd-en {
+			samsung,pins = "gpe3-4";
+			samsung,pin-function = <2>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
+
+		lcd_clk: lcd-clk {
+			samsung,pins = "gpf0-0", "gpf0-1", "gpf0-2", "gpf0-3";
+			samsung,pin-function = <2>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
+
+		lcd_data16: lcd-data-width16 {
+			samsung,pins = "gpf0-7", "gpf1-0", "gpf1-1", "gpf1-2",
+					"gpf1-3", "gpf1-6", "gpf1-7", "gpf2-0",
+					"gpf2-1", "gpf2-2", "gpf2-3", "gpf2-7",
+					"gpf3-0", "gpf3-1", "gpf3-2", "gpf3-3";
+			samsung,pin-function = <2>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
+
+		lcd_data18: lcd-data-width18 {
+			samsung,pins = "gpf0-6", "gpf0-7", "gpf1-0", "gpf1-1",
+					"gpf1-2", "gpf1-3", "gpf1-6", "gpf1-7",
+					"gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3",
+					"gpf2-6", "gpf2-7", "gpf3-0", "gpf3-1",
+					"gpf3-2", "gpf3-3";
+			samsung,pin-function = <2>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
+
+		lcd_data24: lcd-data-width24 {
+			samsung,pins = "gpf0-4", "gpf0-5", "gpf0-6", "gpf0-7",
+					"gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3",
+					"gpf1-4", "gpf1-5", "gpf1-6", "gpf1-7",
+					"gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3",
+					"gpf2-4", "gpf2-5", "gpf2-6", "gpf2-7",
+					"gpf3-0", "gpf3-1", "gpf3-2", "gpf3-3";
+			samsung,pin-function = <2>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	pinctrl@11000000 {