| Message ID | 20190927093603.9140-6-yamada.masahiro@socionext.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | module: various bug-fixes and clean-ups for module namespace | expand |
On Fri, Sep 27, 2019 at 06:36:01PM +0900, Masahiro Yamada wrote: >Running 'make nsdeps' in a clean source tree fails as follows: > >$ make -s clean; make -s defconfig; make nsdeps > [ snip ] >awk: fatal: cannot open file `init/modules.order' for reading (No such file or directory) >make: *** [Makefile;1307: modules.order] Error 2 >make: *** Deleting file 'modules.order' >make: *** Waiting for unfinished jobs.... > >The cause of the error is 'make nsdeps' does not build modules at all. >Set KBUILD_MODULES to fix it. You reported that issue earlier, but having nsdeps depend on modules (see Makefile:1708) resolved that for me. I wonder what I missed. But I won't disagree with you on kbuild advise. :-) Reviewed-by: Matthias Maennich <maennich@google.com> Cheers, Matthias >Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >--- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Makefile b/Makefile >index d456746da347..80ba8efd56bb 100644 >--- a/Makefile >+++ b/Makefile >@@ -616,7 +616,7 @@ endif > # in addition to whatever we do anyway. > # Just "make" or "make all" shall build modules as well > >-ifneq ($(filter all _all modules,$(MAKECMDGOALS)),) >+ifneq ($(filter all _all modules nsdeps,$(MAKECMDGOALS)),) > KBUILD_MODULES := 1 > endif > >-- >2.17.1 >
diff --git a/Makefile b/Makefile index d456746da347..80ba8efd56bb 100644 --- a/Makefile +++ b/Makefile @@ -616,7 +616,7 @@ endif # in addition to whatever we do anyway. # Just "make" or "make all" shall build modules as well -ifneq ($(filter all _all modules,$(MAKECMDGOALS)),) +ifneq ($(filter all _all modules nsdeps,$(MAKECMDGOALS)),) KBUILD_MODULES := 1 endif
Running 'make nsdeps' in a clean source tree fails as follows: $ make -s clean; make -s defconfig; make nsdeps [ snip ] awk: fatal: cannot open file `init/modules.order' for reading (No such file or directory) make: *** [Makefile;1307: modules.order] Error 2 make: *** Deleting file 'modules.order' make: *** Waiting for unfinished jobs.... The cause of the error is 'make nsdeps' does not build modules at all. Set KBUILD_MODULES to fix it. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1