diff mbox series

[v3,22/33] configure: preserve PKG_CONFIG for subdir builds

Message ID 20190924210106.27117-23-alex.bennee@linaro.org
State Superseded
Headers show
Series testing/next (docker,tcg, alpha ;-) | expand

Commit Message

Alex Bennée Sept. 24, 2019, 9 p.m. UTC 
The slirp sub-module complains about not being able to find the glib
library on cross-compiles because it is using the default pkg-config
tool (which isn't installed in our cross-build docker images).
Preserve PKG_CONFIG in our host config and pass it down to slirp.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

---
 Makefile  | 6 +++++-
 configure | 1 +
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé Sept. 25, 2019, 10:25 p.m. UTC | #1 
On 9/24/19 11:00 PM, Alex Bennée wrote:
> The slirp sub-module complains about not being able to find the glib

> library on cross-compiles because it is using the default pkg-config

> tool (which isn't installed in our cross-build docker images).

> Preserve PKG_CONFIG in our host config and pass it down to slirp.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  Makefile  | 6 +++++-

>  configure | 1 +

>  2 files changed, 6 insertions(+), 1 deletion(-)

> 

> diff --git a/Makefile b/Makefile

> index a0c1430b407..8da33595edd 100644

> --- a/Makefile

> +++ b/Makefile

> @@ -510,7 +510,11 @@ capstone/all: .git-submodule-status

>  

>  .PHONY: slirp/all

>  slirp/all: .git-submodule-status

> -	$(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp BUILD_DIR="$(BUILD_DIR)/slirp" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")

> +	$(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp		\

> +		BUILD_DIR="$(BUILD_DIR)/slirp" 			\

> +		PKG_CONFIG="$(PKG_CONFIG)" 				\


Eh it was that easy... nice.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


> +		CC="$(CC)" AR="$(AR)" 	LD="$(LD)" RANLIB="$(RANLIB)"	\

> +		CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")

>  

>  # Compatibility gunk to keep make working across the rename of targets

>  # for recursion, to be removed some time after 4.1.

> diff --git a/configure b/configure

> index 397bb476e19..542f6aea3f6 100755

> --- a/configure

> +++ b/configure

> @@ -7302,6 +7302,7 @@ echo "OBJCOPY=$objcopy" >> $config_host_mak

>  echo "LD=$ld" >> $config_host_mak

>  echo "RANLIB=$ranlib" >> $config_host_mak

>  echo "NM=$nm" >> $config_host_mak

> +echo "PKG_CONFIG=$pkg_config_exe" >> $config_host_mak

>  echo "WINDRES=$windres" >> $config_host_mak

>  echo "CFLAGS=$CFLAGS" >> $config_host_mak

>  echo "CFLAGS_NOPIE=$CFLAGS_NOPIE" >> $config_host_mak

>
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index a0c1430b407..8da33595edd 100644
--- a/Makefile
+++ b/Makefile
@@ -510,7 +510,11 @@  capstone/all: .git-submodule-status
 
 .PHONY: slirp/all
 slirp/all: .git-submodule-status
-	$(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp BUILD_DIR="$(BUILD_DIR)/slirp" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")
+	$(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp		\
+		BUILD_DIR="$(BUILD_DIR)/slirp" 			\
+		PKG_CONFIG="$(PKG_CONFIG)" 				\
+		CC="$(CC)" AR="$(AR)" 	LD="$(LD)" RANLIB="$(RANLIB)"	\
+		CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")
 
 # Compatibility gunk to keep make working across the rename of targets
 # for recursion, to be removed some time after 4.1.
diff --git a/configure b/configure
index 397bb476e19..542f6aea3f6 100755
--- a/configure
+++ b/configure
@@ -7302,6 +7302,7 @@  echo "OBJCOPY=$objcopy" >> $config_host_mak
 echo "LD=$ld" >> $config_host_mak
 echo "RANLIB=$ranlib" >> $config_host_mak
 echo "NM=$nm" >> $config_host_mak
+echo "PKG_CONFIG=$pkg_config_exe" >> $config_host_mak
 echo "WINDRES=$windres" >> $config_host_mak
 echo "CFLAGS=$CFLAGS" >> $config_host_mak
 echo "CFLAGS_NOPIE=$CFLAGS_NOPIE" >> $config_host_mak