| Message ID | 7f5dd2ac9f3504e2699f23e69bc3d8051b729832.1568925097.git.crobinso@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | vhost-user-gpu: Drop trailing json comma | expand |
On Fri, Sep 20, 2019 at 12:34 AM Cole Robinson <crobinso@redhat.com> wrote: > > Trailing comma is not valid json: > > $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq > parse error: Expected another key-value pair at line 5, column 1 > > Signed-off-by: Cole Robinson <crobinso@redhat.com> oh json.. Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in b/contrib/vhost-user-gpu/50-qemu-gpu.json.in > index 658b545864..f5edd097f8 100644 > --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in > +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in > @@ -1,5 +1,5 @@ > { > "description": "QEMU vhost-user-gpu", > "type": "gpu", > - "binary": "@libexecdir@/vhost-user-gpu", > + "binary": "@libexecdir@/vhost-user-gpu" > } > -- > 2.23.0 > > -- Marc-André Lureau
Cole Robinson <crobinso@redhat.com> 于2019年9月20日周五 上午4:34写道： > Trailing comma is not valid json: > > $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq > parse error: Expected another key-value pair at line 5, column 1 > > Signed-off-by: Cole Robinson <crobinso@redhat.com> > Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in > b/contrib/vhost-user-gpu/50-qemu-gpu.json.in > index 658b545864..f5edd097f8 100644 > --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in > +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in > @@ -1,5 +1,5 @@ > { > "description": "QEMU vhost-user-gpu", > "type": "gpu", > - "binary": "@libexecdir@/vhost-user-gpu", > + "binary": "@libexecdir@/vhost-user-gpu" > } > -- > 2.23.0 > > > <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Cole Robinson <<a href="mailto:crobinso@redhat.com">crobinso@redhat.com</a>> 于2019年9月20日周五 上午4:34写道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Trailing comma is not valid json:<br> <br> $ cat contrib/vhost-user-gpu/<a href="http://50-qemu-gpu.json.in" rel="noreferrer" target="_blank">50-qemu-gpu.json.in</a> | jq<br> parse error: Expected another key-value pair at line 5, column 1<br> <br> Signed-off-by: Cole Robinson <<a href="mailto:crobinso@redhat.com" target="_blank">crobinso@redhat.com</a>><br></blockquote><div><br></div><div><br></div><div>Reviewed-by: Li Qiang <<a href="mailto:liq3ea@gmail.com">liq3ea@gmail.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> ---<br> contrib/vhost-user-gpu/<a href="http://50-qemu-gpu.json.in" rel="noreferrer" target="_blank">50-qemu-gpu.json.in</a> | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/contrib/vhost-user-gpu/<a href="http://50-qemu-gpu.json.in" rel="noreferrer" target="_blank">50-qemu-gpu.json.in</a> b/contrib/vhost-user-gpu/<a href="http://50-qemu-gpu.json.in" rel="noreferrer" target="_blank">50-qemu-gpu.json.in</a><br> index 658b545864..f5edd097f8 100644<br> --- a/contrib/vhost-user-gpu/<a href="http://50-qemu-gpu.json.in" rel="noreferrer" target="_blank">50-qemu-gpu.json.in</a><br> +++ b/contrib/vhost-user-gpu/<a href="http://50-qemu-gpu.json.in" rel="noreferrer" target="_blank">50-qemu-gpu.json.in</a><br> @@ -1,5 +1,5 @@<br> {<br> "description": "QEMU vhost-user-gpu",<br> "type": "gpu",<br> - "binary": "@libexecdir@/vhost-user-gpu",<br> + "binary": "@libexecdir@/vhost-user-gpu"<br> }<br> -- <br> 2.23.0<br> <br> <br> </blockquote></div></div>
On 9/19/19 10:33 PM, Cole Robinson wrote: > Trailing comma is not valid json: > > $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq > parse error: Expected another key-value pair at line 5, column 1 Shouldn't we add this as a test? > Signed-off-by: Cole Robinson <crobinso@redhat.com> > --- > contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in b/contrib/vhost-user-gpu/50-qemu-gpu.json.in > index 658b545864..f5edd097f8 100644 > --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in > +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in > @@ -1,5 +1,5 @@ > { > "description": "QEMU vhost-user-gpu", > "type": "gpu", > - "binary": "@libexecdir@/vhost-user-gpu", > + "binary": "@libexecdir@/vhost-user-gpu" > } > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in b/contrib/vhost-user-gpu/50-qemu-gpu.json.in index 658b545864..f5edd097f8 100644 --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in @@ -1,5 +1,5 @@ { "description": "QEMU vhost-user-gpu", "type": "gpu", - "binary": "@libexecdir@/vhost-user-gpu", + "binary": "@libexecdir@/vhost-user-gpu" }
Trailing comma is not valid json: $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq parse error: Expected another key-value pair at line 5, column 1 Signed-off-by: Cole Robinson <crobinso@redhat.com> --- contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.23.0