diff mbox series

kbuild: get rid of $(realpath ...) from scripts/mkmakefile

Message ID 20190822035911.23478-1-yamada.masahiro@socionext.com
State Accepted
Commit 9c3ad4c14f7a3ac870d660bbc5f9961a8a79f356
Headers show
Series kbuild: get rid of $(realpath ...) from scripts/mkmakefile | expand

Commit Message

Masahiro Yamada Aug. 22, 2019, 3:59 a.m. UTC
Both relative path and absolute path have pros and cons. For example,
we can move the source and objtree around together by using the
relative path to the source tree.

Do not force the absolute path to the source tree. If you prefer the
absolute path, you can specify KBUILD_ABS_SRCTREE=1.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 scripts/mkmakefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

Comments

Masahiro Yamada Aug. 28, 2019, 4:45 p.m. UTC | #1
On Thu, Aug 22, 2019 at 12:59 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>

> Both relative path and absolute path have pros and cons. For example,

> we can move the source and objtree around together by using the

> relative path to the source tree.

>

> Do not force the absolute path to the source tree. If you prefer the

> absolute path, you can specify KBUILD_ABS_SRCTREE=1.

>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---


Applied to linux-kbuild.

>  scripts/mkmakefile | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/scripts/mkmakefile b/scripts/mkmakefile

> index 4d0faebb1719..1cb174751429 100755

> --- a/scripts/mkmakefile

> +++ b/scripts/mkmakefile

> @@ -12,6 +12,6 @@ if [ "${quiet}" != "silent_" ]; then

>  fi

>

>  cat << EOF > Makefile

> -# Automatically generated by $(realpath $0): don't edit

> -include $(realpath $1/Makefile)

> +# Automatically generated by $0: don't edit

> +include $1/Makefile

>  EOF

> --

> 2.17.1

>



-- 
Best Regards
Masahiro Yamada
diff mbox series

Patch

diff --git a/scripts/mkmakefile b/scripts/mkmakefile
index 4d0faebb1719..1cb174751429 100755
--- a/scripts/mkmakefile
+++ b/scripts/mkmakefile
@@ -12,6 +12,6 @@  if [ "${quiet}" != "silent_" ]; then
 fi
 
 cat << EOF > Makefile
-# Automatically generated by $(realpath $0): don't edit
-include $(realpath $1/Makefile)
+# Automatically generated by $0: don't edit
+include $1/Makefile
 EOF