| Message ID | 20190809144043.476786-10-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | de6f97b2bace0e2eb6c3a86e124d1e652a587b56 |
| Headers | show |
| Series | v2: ARM: move lpc32xx to multiplatform | expand |
On Fri, 2019-08-09 at 16:40 +0200, Arnd Bergmann wrote: > compile-testing this driver on other architectures showed > multiple warnings: > > drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_drv_probe': > drivers/net/ethernet/nxp/lpc_eth.c:1337:19: warning: format '%d' expects argument of type 'int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=] > > drivers/net/ethernet/nxp/lpc_eth.c:1342:19: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > > Use format strings that work on all architectures. [] > diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c [] > @@ -1333,13 +1333,14 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) > pldat->dma_buff_base_p = dma_handle; > > netdev_dbg(ndev, "IO address space :%pR\n", res); > - netdev_dbg(ndev, "IO address size :%d\n", resource_size(res)); > + netdev_dbg(ndev, "IO address size :%zd\n", > + (size_t)resource_size(res)); Ideally all these would use %zu not %zd
On Fri, Aug 9, 2019 at 6:30 PM Joe Perches <joe@perches.com> wrote: > > @@ -1333,13 +1333,14 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) > > pldat->dma_buff_base_p = dma_handle; > > > > netdev_dbg(ndev, "IO address space :%pR\n", res); > > - netdev_dbg(ndev, "IO address size :%d\n", resource_size(res)); > > + netdev_dbg(ndev, "IO address size :%zd\n", > > + (size_t)resource_size(res)); > > Ideally all these would use %zu not %zd Ok, changed now. Arnd
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 797bdbbcef76..96d509c418bf 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -1333,13 +1333,14 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) pldat->dma_buff_base_p = dma_handle; netdev_dbg(ndev, "IO address space :%pR\n", res); - netdev_dbg(ndev, "IO address size :%d\n", resource_size(res)); + netdev_dbg(ndev, "IO address size :%zd\n", + (size_t)resource_size(res)); netdev_dbg(ndev, "IO address (mapped) :0x%p\n", pldat->net_base); netdev_dbg(ndev, "IRQ number :%d\n", ndev->irq); - netdev_dbg(ndev, "DMA buffer size :%d\n", pldat->dma_buff_size); - netdev_dbg(ndev, "DMA buffer P address :0x%08x\n", - pldat->dma_buff_base_p); + netdev_dbg(ndev, "DMA buffer size :%zd\n", pldat->dma_buff_size); + netdev_dbg(ndev, "DMA buffer P address :%pad\n", + &pldat->dma_buff_base_p); netdev_dbg(ndev, "DMA buffer V address :0x%p\n", pldat->dma_buff_base_v); @@ -1386,8 +1387,8 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) if (ret) goto err_out_unregister_netdev; - netdev_info(ndev, "LPC mac at 0x%08x irq %d\n", - res->start, ndev->irq); + netdev_info(ndev, "LPC mac at 0x%08lx irq %d\n", + (unsigned long)res->start, ndev->irq); device_init_wakeup(dev, 1); device_set_wakeup_enable(dev, 0);
compile-testing this driver on other architectures showed multiple warnings: drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_drv_probe': drivers/net/ethernet/nxp/lpc_eth.c:1337:19: warning: format '%d' expects argument of type 'int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=] drivers/net/ethernet/nxp/lpc_eth.c:1342:19: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] Use format strings that work on all architectures. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/nxp/lpc_eth.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) -- 2.20.0