[v5,21/29] compat_ioctl: remove HIDIO translation

Message ID	20190730200145.1081541-2-arnd@arndb.de
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Arnd Bergmann <arnd@arndb.de> To: Alexander Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH v5 21/29] compat_ioctl: remove HIDIO translation Date: Tue, 30 Jul 2019 22:01:26 +0200 Message-Id: <20190730200145.1081541-2-arnd@arndb.de> In-Reply-To: <20190730200145.1081541-1-arnd@arndb.de> References: <20190730192552.4014288-1-arnd@arndb.de> <20190730200145.1081541-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk
Series	compat_ioctl.c removal, part 1/3 \| expand [v5,00/29] compat_ioctl.c removal, part 1/3 [v5,01/29] fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP [v5,02/29] FIGETBSZ: fix compat [v5,03/29] compat: itanic doesn't have one [v5,04/29] do_vfs_ioctl(): use saner types [v5,05/29] compat: move FS_IOC_RESVSP_32 handling to fs/ioctl.c [v5,06/29] compat_sys_ioctl(): make parallel to do_vfs_ioctl() [v5,07/29] ceph: fix compat_ioctl for ceph_dir_operations [v5,08/29] compat_ioctl: drop FIOQSIZE table entry [v5,09/29] compat_ioctl: pppoe: fix PPPOEIOCSFWD handling [v5,10/29] compat_ioctl: add compat_ptr_ioctl() [v5,11/29] compat_ioctl: move rtc handling into rtc-dev.c [v5,12/29] compat_ioctl: move drivers to compat_ptr_ioctl [v5,14/29] compat_ioctl: use correct compat_ptr() translation in drivers [v5,15/29] compat_ioctl: move tape handling into drivers [v5,17/29] compat_ioctl: move isdn/capi ioctl translation into driver [v5,18/29] compat_ioctl: move rfcomm handlers into driver [v5,19/29] compat_ioctl: move hci_sock handlers into driver [v5,20/29] compat_ioctl: remove HCIUART handling [v5,21/29] compat_ioctl: remove HIDIO translation [v5,22/29] compat_ioctl: remove translation for sound ioctls [v5,23/29] compat_ioctl: remove IGNORE_IOCTL() [v5,24/29] compat_ioctl: remove /dev/random commands [v5,25/29] compat_ioctl: remove joystick ioctl translation [v5,26/29] compat_ioctl: remove PCI ioctl translation [v5,27/29] compat_ioctl: remove /dev/raw ioctl translation [v5,28/29] compat_ioctl: remove last RAID handling code [v5,29/29] compat_ioctl: remove unused convert_in_user macro

Message ID

20190730200145.1081541-2-arnd@arndb.de

State

Superseded

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-kernel-owner@vger.kernel.org designates 209.132.180.67
	as permitted sender) client-ip=209.132.180.67; 
From: Arnd Bergmann <arnd@arndb.de>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH v5 21/29] compat_ioctl: remove HIDIO translation
Date: Tue, 30 Jul 2019 22:01:26 +0200
Message-Id: <20190730200145.1081541-2-arnd@arndb.de>
In-Reply-To: <20190730200145.1081541-1-arnd@arndb.de>
References: <20190730192552.4014288-1-arnd@arndb.de>
	<20190730200145.1081541-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Series

compat_ioctl.c removal, part 1/3 | expand

Commit Message

Arnd Bergmann July 30, 2019, 8:01 p.m. UTC

The two drivers implementing these both gained proper compat_ioctl()
handlers a long time ago with commits bb6c8d8fa9b5 ("HID: hiddev:
Add 32bit ioctl compatibilty") and ae5e49c79c05 ("HID: hidraw: add
compatibility ioctl() for 32-bit applications."), so the lists in
fs/compat_ioctl.c are no longer used.

It appears that the lists were also incomplete, so the translation
didn't actually work correctly when it was still in use.

Remove them as cleanup.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 fs/compat_ioctl.c | 17 -----------------
 1 file changed, 17 deletions(-)

-- 
2.20.0

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index 758b8b934b70..03da7934a351 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -640,23 +640,6 @@  COMPATIBLE_IOCTL(PCIIOC_CONTROLLER)
 COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_IO)
 COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_MEM)
 COMPATIBLE_IOCTL(PCIIOC_WRITE_COMBINE)
-/* hiddev */
-COMPATIBLE_IOCTL(HIDIOCGVERSION)
-COMPATIBLE_IOCTL(HIDIOCAPPLICATION)
-COMPATIBLE_IOCTL(HIDIOCGDEVINFO)
-COMPATIBLE_IOCTL(HIDIOCGSTRING)
-COMPATIBLE_IOCTL(HIDIOCINITREPORT)
-COMPATIBLE_IOCTL(HIDIOCGREPORT)
-COMPATIBLE_IOCTL(HIDIOCSREPORT)
-COMPATIBLE_IOCTL(HIDIOCGREPORTINFO)
-COMPATIBLE_IOCTL(HIDIOCGFIELDINFO)
-COMPATIBLE_IOCTL(HIDIOCGUSAGE)
-COMPATIBLE_IOCTL(HIDIOCSUSAGE)
-COMPATIBLE_IOCTL(HIDIOCGUCODE)
-COMPATIBLE_IOCTL(HIDIOCGFLAG)
-COMPATIBLE_IOCTL(HIDIOCSFLAG)
-COMPATIBLE_IOCTL(HIDIOCGCOLLECTIONINDEX)
-COMPATIBLE_IOCTL(HIDIOCGCOLLECTIONINFO)
 /* joystick */
 COMPATIBLE_IOCTL(JSIOCGVERSION)
 COMPATIBLE_IOCTL(JSIOCGAXES)

[v5,21/29] compat_ioctl: remove HIDIO translation

Commit Message

Patch