| Message ID | 20190727030110.17208-1-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | cb36955a5569f1ff17a42ae93264ef391c013a97 |
| Headers | show |
| Series | gen_compile_commands: lower the entry count threshold | expand |
On Sat, Jul 27, 2019 at 12:01:10PM +0900, Masahiro Yamada wrote: > Running gen_compile_commands.py after building with allnoconfig > gave this: > > $ ./scripts/gen_compile_commands.py > WARNING: Found 449 entries. Have you compiled the kernel? Thanks for catching this! I should have tried with allnoconfig when I originally did this, but I didn't think of it. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Tom Roeder <tmroeder@google.com> > --- > > scripts/gen_compile_commands.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/gen_compile_commands.py b/scripts/gen_compile_commands.py > index 7915823b92a5..c458696ef3a7 100755 > --- a/scripts/gen_compile_commands.py > +++ b/scripts/gen_compile_commands.py > @@ -21,9 +21,9 @@ _LINE_PATTERN = r'^cmd_[^ ]*\.o := (.* )([^ ]*\.c)$' > _VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] > > # A kernel build generally has over 2000 entries in its compile_commands.json > -# database. If this code finds 500 or fewer, then warn the user that they might > +# database. If this code finds 300 or fewer, then warn the user that they might > # not have all the .cmd files, and they might need to compile the kernel. > -_LOW_COUNT_THRESHOLD = 500 > +_LOW_COUNT_THRESHOLD = 300 > > > def parse_arguments(): > -- > 2.17.1 >
On Fri, Jul 26, 2019 at 8:01 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Running gen_compile_commands.py after building with allnoconfig > gave this: > > $ ./scripts/gen_compile_commands.py > WARNING: Found 449 entries. Have you compiled the kernel? > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> This potentially may need to go lower for other arch's allnoconfig. I'm guessing you tested x86_64? Acked-by: Nick Desaulniers <ndesaulniers@google.com> > --- > > scripts/gen_compile_commands.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/gen_compile_commands.py b/scripts/gen_compile_commands.py > index 7915823b92a5..c458696ef3a7 100755 > --- a/scripts/gen_compile_commands.py > +++ b/scripts/gen_compile_commands.py > @@ -21,9 +21,9 @@ _LINE_PATTERN = r'^cmd_[^ ]*\.o := (.* )([^ ]*\.c)$' > _VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] > > # A kernel build generally has over 2000 entries in its compile_commands.json > -# database. If this code finds 500 or fewer, then warn the user that they might > +# database. If this code finds 300 or fewer, then warn the user that they might > # not have all the .cmd files, and they might need to compile the kernel. > -_LOW_COUNT_THRESHOLD = 500 > +_LOW_COUNT_THRESHOLD = 300 > > > def parse_arguments(): > -- > 2.17.1 > -- Thanks, ~Nick Desaulniers
diff --git a/scripts/gen_compile_commands.py b/scripts/gen_compile_commands.py index 7915823b92a5..c458696ef3a7 100755 --- a/scripts/gen_compile_commands.py +++ b/scripts/gen_compile_commands.py @@ -21,9 +21,9 @@ _LINE_PATTERN = r'^cmd_[^ ]*\.o := (.* )([^ ]*\.c)$' _VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] # A kernel build generally has over 2000 entries in its compile_commands.json -# database. If this code finds 500 or fewer, then warn the user that they might +# database. If this code finds 300 or fewer, then warn the user that they might # not have all the .cmd files, and they might need to compile the kernel. -_LOW_COUNT_THRESHOLD = 500 +_LOW_COUNT_THRESHOLD = 300 def parse_arguments():
Running gen_compile_commands.py after building with allnoconfig gave this: $ ./scripts/gen_compile_commands.py WARNING: Found 449 entries. Have you compiled the kernel? Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/gen_compile_commands.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1