| Message ID | 20190709185626.3275510-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | a1cd4e4324afa4d8a2d6d0ce16bc689d6bab02cc |
| Headers | show |
| Series | [net-next] net: dsa: vsc73xx: fix NET_DSA and OF dependencies | expand |
From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 9 Jul 2019 20:55:55 +0200 > The restructuring of the driver got the dependencies wrong: without > CONFIG_NET_DSA we get this build failure: > > WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX > Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=y] && NET_DSA [=n] > Selected by [m]: > - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y] > > ERROR: "dsa_unregister_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! > ERROR: "dsa_switch_alloc" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! > ERROR: "dsa_register_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! > > Add the appropriate dependencies. > > Fixes: 95711cd5f0b4 ("net: dsa: vsc73xx: Split vsc73xx driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks Arnd.
diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig index cf9dbd15dd2d..f6232ce8481f 100644 --- a/drivers/net/dsa/Kconfig +++ b/drivers/net/dsa/Kconfig @@ -111,6 +111,8 @@ config NET_DSA_VITESSE_VSC73XX config NET_DSA_VITESSE_VSC73XX_SPI tristate "Vitesse VSC7385/7388/7395/7398 SPI mode support" + depends on OF + depends on NET_DSA depends on SPI select NET_DSA_VITESSE_VSC73XX ---help--- @@ -119,6 +121,8 @@ config NET_DSA_VITESSE_VSC73XX_SPI config NET_DSA_VITESSE_VSC73XX_PLATFORM tristate "Vitesse VSC7385/7388/7395/7398 Platform mode support" + depends on OF + depends on NET_DSA depends on HAS_IOMEM select NET_DSA_VITESSE_VSC73XX ---help---
The restructuring of the driver got the dependencies wrong: without CONFIG_NET_DSA we get this build failure: WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=y] && NET_DSA [=n] Selected by [m]: - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y] ERROR: "dsa_unregister_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! ERROR: "dsa_switch_alloc" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! ERROR: "dsa_register_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! Add the appropriate dependencies. Fixes: 95711cd5f0b4 ("net: dsa: vsc73xx: Split vsc73xx driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/dsa/Kconfig | 4 ++++ 1 file changed, 4 insertions(+) -- 2.20.0