diff mbox series

ASoC: meson: axg-card: remove useless check on codec

Message ID 20190628081708.22039-1-jbrunet@baylibre.com
State Accepted
Commit 8fc22fa4b2cd983e4c542d1841b3d2212ad18ed4
Headers show
Series ASoC: meson: axg-card: remove useless check on codec | expand

Commit Message

Jerome Brunet June 28, 2019, 8:17 a.m. UTC 
While checking cpus before dereferencing the pointer is required, it is
not necessary for codecs. 'codec' can't possibly be NULL in the loop

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

---
 sound/soc/meson/axg-card.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.21.0
diff mbox series

Patch

diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c
index 70bb0cbad233..14a8321744da 100644
--- a/sound/soc/meson/axg-card.c
+++ b/sound/soc/meson/axg-card.c
@@ -118,8 +118,7 @@  static void axg_card_clean_references(struct axg_card *priv)
 			if (link->cpus)
 				of_node_put(link->cpus->of_node);
 			for_each_link_codecs(link, j, codec)
-				if (codec)
-					of_node_put(codec->of_node);
+				of_node_put(codec->of_node);
 		}
 	}