| Message ID | 20190617130149.1782930-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 521a503f5247de9a5cbc381f15c466a6c6f2793c |
| Headers | show |
| Series | soc: ti: fix irq-ti-sci link error | expand |
On 15:01-20190617, Arnd Bergmann wrote: > The irqchip driver depends on the SoC specific driver, but we want > to be able to compile-test it elsewhere: > > WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN > Depends on [n]: SOC_TI [=n] > Selected by [y]: > - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y] > > drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe': > irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain' > > Rearrange the Kconfig and Makefile so we build the soc driver whenever > its users are there, regardless of the SOC_TI option. > > Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator") > Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/soc/Makefile | 2 +- > drivers/soc/ti/Kconfig | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > index 524ecdc2a9bb..2ec355003524 100644 > --- a/drivers/soc/Makefile > +++ b/drivers/soc/Makefile > @@ -22,7 +22,7 @@ obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ > obj-$(CONFIG_SOC_SAMSUNG) += samsung/ > obj-y += sunxi/ > obj-$(CONFIG_ARCH_TEGRA) += tegra/ > -obj-$(CONFIG_SOC_TI) += ti/ > +obj-y += ti/ > obj-$(CONFIG_ARCH_U8500) += ux500/ > obj-$(CONFIG_PLAT_VERSATILE) += versatile/ > obj-y += xilinx/ > diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig > index ea0859f7b185..d7d50d48d05d 100644 > --- a/drivers/soc/ti/Kconfig > +++ b/drivers/soc/ti/Kconfig > @@ -75,10 +75,10 @@ config TI_SCI_PM_DOMAINS > called ti_sci_pm_domains. Note this is needed early in boot before > rootfs may be available. > > +endif # SOC_TI > + > config TI_SCI_INTA_MSI_DOMAIN > bool > select GENERIC_MSI_IRQ_DOMAIN > help > Driver to enable Interrupt Aggregator specific MSI Domain. > - > -endif # SOC_TI > -- > 2.20.0 > Looks fine to me. Lokesh? -- Regards, Nishanth Menon
On 17/06/19 6:31 PM, Arnd Bergmann wrote: > The irqchip driver depends on the SoC specific driver, but we want > to be able to compile-test it elsewhere: > > WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN > Depends on [n]: SOC_TI [=n] > Selected by [y]: > - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y] > > drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe': > irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain' > > Rearrange the Kconfig and Makefile so we build the soc driver whenever > its users are there, regardless of the SOC_TI option. > > Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator") > Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Looks like this is a side effect of the patch a6b112b04355b ("arm64: arch_k3: Fix kconfig dependency warning"). $Patch looks good to me. Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> Thanks and regards, Lokesh > --- > drivers/soc/Makefile | 2 +- > drivers/soc/ti/Kconfig | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > index 524ecdc2a9bb..2ec355003524 100644 > --- a/drivers/soc/Makefile > +++ b/drivers/soc/Makefile > @@ -22,7 +22,7 @@ obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ > obj-$(CONFIG_SOC_SAMSUNG) += samsung/ > obj-y += sunxi/ > obj-$(CONFIG_ARCH_TEGRA) += tegra/ > -obj-$(CONFIG_SOC_TI) += ti/ > +obj-y += ti/ > obj-$(CONFIG_ARCH_U8500) += ux500/ > obj-$(CONFIG_PLAT_VERSATILE) += versatile/ > obj-y += xilinx/ > diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig > index ea0859f7b185..d7d50d48d05d 100644 > --- a/drivers/soc/ti/Kconfig > +++ b/drivers/soc/ti/Kconfig > @@ -75,10 +75,10 @@ config TI_SCI_PM_DOMAINS > called ti_sci_pm_domains. Note this is needed early in boot before > rootfs may be available. > > +endif # SOC_TI > + > config TI_SCI_INTA_MSI_DOMAIN > bool > select GENERIC_MSI_IRQ_DOMAIN > help > Driver to enable Interrupt Aggregator specific MSI Domain. > - > -endif # SOC_TI >
On 6/17/19 6:01 AM, Arnd Bergmann wrote: > The irqchip driver depends on the SoC specific driver, but we want > to be able to compile-test it elsewhere: > > WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN > Depends on [n]: SOC_TI [=n] > Selected by [y]: > - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y] > > drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe': > irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain' > > Rearrange the Kconfig and Makefile so we build the soc driver whenever > its users are there, regardless of the SOC_TI option. > > Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator") > Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Thanks Arnd. Will you be able to add it to your fixes queue. FWIW, Acked-by: Santosh Shilimkar <ssantosh@kernle.org>
On Mon, Jul 1, 2019 at 10:36 AM <santosh.shilimkar@oracle.com> wrote: > > On 6/17/19 6:01 AM, Arnd Bergmann wrote: > > The irqchip driver depends on the SoC specific driver, but we want > > to be able to compile-test it elsewhere: > > > > WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN > > Depends on [n]: SOC_TI [=n] > > Selected by [y]: > > - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y] > > > > drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe': > > irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain' > > > > Rearrange the Kconfig and Makefile so we build the soc driver whenever > > its users are there, regardless of the SOC_TI option. > > > > Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator") > > Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > Thanks Arnd. Will you be able to add it to your fixes queue. > > FWIW, Acked-by: Santosh Shilimkar <ssantosh@kernle.org> Cc:ing to arm@kernel.org is the best way to make sure it surfaces. Also, please do Acked-by on separate line so the tools catch it next time (also, check for typos. :) Applying to fixes. -Olof
On 7/1/19 3:24 PM, Olof Johansson wrote: > On Mon, Jul 1, 2019 at 10:36 AM <santosh.shilimkar@oracle.com> wrote: >> >> On 6/17/19 6:01 AM, Arnd Bergmann wrote: >>> The irqchip driver depends on the SoC specific driver, but we want >>> to be able to compile-test it elsewhere: >>> >>> WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN >>> Depends on [n]: SOC_TI [=n] >>> Selected by [y]: >>> - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y] >>> >>> drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe': >>> irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain' >>> >>> Rearrange the Kconfig and Makefile so we build the soc driver whenever >>> its users are there, regardless of the SOC_TI option. >>> >>> Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator") >>> Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support") >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >>> --- >> Thanks Arnd. Will you be able to add it to your fixes queue. >> >> FWIW, Acked-by: Santosh Shilimkar <ssantosh@kernle.org> > > Cc:ing to arm@kernel.org is the best way to make sure it surfaces. > > Also, please do Acked-by on separate line so the tools catch it next Will do.. > time (also, check for typos. :) > :- ) > Applying to fixes. Thanks for picking it up.
diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index 524ecdc2a9bb..2ec355003524 100644 --- a/drivers/soc/Makefile +++ b/drivers/soc/Makefile @@ -22,7 +22,7 @@ obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ obj-$(CONFIG_SOC_SAMSUNG) += samsung/ obj-y += sunxi/ obj-$(CONFIG_ARCH_TEGRA) += tegra/ -obj-$(CONFIG_SOC_TI) += ti/ +obj-y += ti/ obj-$(CONFIG_ARCH_U8500) += ux500/ obj-$(CONFIG_PLAT_VERSATILE) += versatile/ obj-y += xilinx/ diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig index ea0859f7b185..d7d50d48d05d 100644 --- a/drivers/soc/ti/Kconfig +++ b/drivers/soc/ti/Kconfig @@ -75,10 +75,10 @@ config TI_SCI_PM_DOMAINS called ti_sci_pm_domains. Note this is needed early in boot before rootfs may be available. +endif # SOC_TI + config TI_SCI_INTA_MSI_DOMAIN bool select GENERIC_MSI_IRQ_DOMAIN help Driver to enable Interrupt Aggregator specific MSI Domain. - -endif # SOC_TI
The irqchip driver depends on the SoC specific driver, but we want to be able to compile-test it elsewhere: WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN Depends on [n]: SOC_TI [=n] Selected by [y]: - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y] drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe': irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain' Rearrange the Kconfig and Makefile so we build the soc driver whenever its users are there, regardless of the SOC_TI option. Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator") Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/soc/Makefile | 2 +- drivers/soc/ti/Kconfig | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.20.0