diff mbox series

[v17,20/24] target/rx: Use prt_ldmi for XCHG_mr disassembly

Message ID 20190607091116.49044-21-ysato@users.sourceforge.jp
State Superseded
Headers show
Series None | expand

Commit Message

Yoshinori Sato June 7, 2019, 9:11 a.m. UTC 
From: Richard Henderson <richard.henderson@linaro.org>


Note that the ld == 3 case handled by prt_ldmi is decoded as
XCHG_rr and cannot appear here.

Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>

---
 target/rx/disas.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

-- 
2.11.0

Comments

Philippe Mathieu-Daudé June 7, 2019, 1:43 p.m. UTC | #1 
On 6/7/19 11:11 AM, Yoshinori Sato wrote:
> From: Richard Henderson <richard.henderson@linaro.org>

> 

> Note that the ld == 3 case handled by prt_ldmi is decoded as

> XCHG_rr and cannot appear here.

> 

> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Again:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>

> ---

>  target/rx/disas.c | 8 +-------

>  1 file changed, 1 insertion(+), 7 deletions(-)

> 

> diff --git a/target/rx/disas.c b/target/rx/disas.c

> index 515b365528..db10385fd0 100644

> --- a/target/rx/disas.c

> +++ b/target/rx/disas.c

> @@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a)

>  /* xchg dsp[rs].<mi>,rd */

>  static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)

>  {

> -    static const char msize[][4] = {

> -        "b", "w", "l", "ub", "uw",

> -    };

> -    char dsp[8];

> -

> -    rx_index_addr(ctx, dsp, a->ld, a->mi);

> -    prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);

> +    prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);

>      return true;

>  }

>  

>
diff mbox series

Patch

diff --git a/target/rx/disas.c b/target/rx/disas.c
index 515b365528..db10385fd0 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -366,13 +366,7 @@  static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a)
 /* xchg dsp[rs].<mi>,rd */
 static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
 {
-    static const char msize[][4] = {
-        "b", "w", "l", "ub", "uw",
-    };
-    char dsp[8];
-
-    rx_index_addr(ctx, dsp, a->ld, a->mi);
-    prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);
+    prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);
     return true;
 }