@@ -719,8 +719,8 @@ merge_or_add_vmap_area(struct vmap_area *va,
/* Check and update the tree if needed. */
augment_tree_propagate_from(sibling);
- /* Remove this VA, it has been merged. */
- unlink_va(va, root);
+ if (merged)
+ unlink_va(va, root);
/* Free vmap_area object. */
kmem_cache_free(vmap_area_cachep, va);
@@ -746,9 +746,6 @@ merge_or_add_vmap_area(struct vmap_area *va,
/* Check and update the tree if needed. */
augment_tree_propagate_from(sibling);
- /* Remove this VA, it has been merged. */
- unlink_va(va, root);
-
/* Free vmap_area object. */
kmem_cache_free(vmap_area_cachep, va);
-------------------------------------------------------------------------------
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/master boot bisection: next-20190603 on jetson-tk1 Summary: Start: ae3cad8f39cc Add linux-next specific files for 20190603 Details: https://kernelci.org/boot/id/5cf4e76059b514265fd51501 Plain log: https://storage.kernelci.org//next/master/next-20190603/arm/multi_v7_defconfig+CONFIG_SMP=n/gcc-8/lab-mhart/boot-tegra124-jetson-tk1.txt HTML log: https://storage.kernelci.org//next/master/next-20190603/arm/multi_v7_defconfig+CONFIG_SMP=n/gcc-8/lab-mhart/boot-tegra124-jetson-tk1.html Result: 728e0fbf263e mm/vmalloc.c: get rid of one single unlink_va() when merge Checks: revert: PASS verify: PASS Parameters: Tree: next URL: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: master Target: jetson-tk1 CPU arch: arm Lab: lab-mhart Compiler: gcc-8 Config: multi_v7_defconfig+CONFIG_SMP=n Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 728e0fbf263e3ed359c10cb13623390564102881 Author: Uladzislau Rezki (Sony) <urezki@gmail.com> Date: Sat Jun 1 12:20:19 2019 +1000 mm/vmalloc.c: get rid of one single unlink_va() when merge It does not make sense to try to "unlink" the node that is definitely not linked with a list nor tree. On the first merge step VA just points to the previously disconnected busy area. On the second step, check if the node has been merged and do "unlink" if so, because now it points to an object that must be linked. Link: http://lkml.kernel.org/r/20190527151843.27416-4-urezki@gmail.com Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> Acked-by: Hillf Danton <hdanton@sina.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Joel Fernandes <joelaf@google.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Michal Hocko <mhocko@suse.com> Cc: Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com> Cc: Roman Gushchin <guro@fb.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Tejun Heo <tj@kernel.org> Cc: Thomas Garnier <thgarnie@google.com> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a] Linux 5.2-rc3 git bisect good f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a # bad: [ae3cad8f39ccf8d31775d9737488bccf0e44d370] Add linux-next specific files for 20190603 git bisect bad ae3cad8f39ccf8d31775d9737488bccf0e44d370 # good: [8ff6f4c6e067a9d3f3bbacf02c4ea5eb81fe2c6a] Merge remote-tracking branch 'crypto/master' git bisect good 8ff6f4c6e067a9d3f3bbacf02c4ea5eb81fe2c6a # good: [6c93755861ce6a6dd904df9cdae9f08671132dbe] Merge remote-tracking branch 'iommu/next' git bisect good 6c93755861ce6a6dd904df9cdae9f08671132dbe # good: [1a567956cb3be5754d94ce9380a2151e57e204a7] Merge remote-tracking branch 'cgroup/for-next' git bisect good 1a567956cb3be5754d94ce9380a2151e57e204a7 # good: [a6878ca73cf30b83efbdfb1ecc443d7cfb2d8193] Merge remote-tracking branch 'rtc/rtc-next' git bisect good a6878ca73cf30b83efbdfb1ecc443d7cfb2d8193 # bad: [b2b94a9c4f8fc4229cd8b14d8417fc491e5f5d7c] mm, memcg: make memory.emin the baseline for utilisation determination git bisect bad b2b94a9c4f8fc4229cd8b14d8417fc491e5f5d7c # good: [e824d3a072bd3f93a0c7616dee4bdb3410e0a767] memcg, fsnotify: no oom-kill for remote memcg charging git bisect good e824d3a072bd3f93a0c7616dee4bdb3410e0a767 # good: [83f89893bd05fe97b43cbe7f5c2eacbb0fdc966a] drivers/base/memory: pass a block_id to init_memory_block() git bisect good 83f89893bd05fe97b43cbe7f5c2eacbb0fdc966a # bad: [8d388102126d935b8d7294162f6b4ebf6b0494c5] tools/vm/slabinfo: add option to sort by partial slabs git bisect bad 8d388102126d935b8d7294162f6b4ebf6b0494c5 # good: [df18a3805de35506cd05da7aceba3704c8ec6962] mm/vmalloc.c: remove "node" argument git bisect good df18a3805de35506cd05da7aceba3704c8ec6962 # bad: [adc7c46cd31f1a3ca27508cb9435187b3c6539a4] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned git bisect bad adc7c46cd31f1a3ca27508cb9435187b3c6539a4 # bad: [728e0fbf263e3ed359c10cb13623390564102881] mm/vmalloc.c: get rid of one single unlink_va() when merge git bisect bad 728e0fbf263e3ed359c10cb13623390564102881 # good: [1ed20f4bc22412db94535d4df384082c98903da9] mm/vmalloc.c: preload a CPU with one object for split purpose git bisect good 1ed20f4bc22412db94535d4df384082c98903da9 # first bad commit: [728e0fbf263e3ed359c10cb13623390564102881] mm/vmalloc.c: get rid of one single unlink_va() when merge -------------------------------------------------------------------------------