| Message ID | 1366986053-5126-1-git-send-email-julien.grall@linaro.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, 26 Apr 2013, Julien Grall wrote: > nr_lrs is only used in gic.c > > Signed-off-by: Julien Grall <julien.grall@linaro.org> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > xen/arch/arm/gic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c > index 35376ef..bc8faf2 100644 > --- a/xen/arch/arm/gic.c > +++ b/xen/arch/arm/gic.c > @@ -53,7 +53,7 @@ static irq_desc_t irq_desc[NR_IRQS]; > static DEFINE_PER_CPU(irq_desc_t[NR_LOCAL_IRQS], local_irq_desc); > static DEFINE_PER_CPU(uint64_t, lr_mask); > > -unsigned nr_lrs; > +static unsigned nr_lrs; > > irq_desc_t *__irq_to_desc(int irq) > { > -- > 1.7.10.4 >
On Fri, 2013-04-26 at 15:29 +0100, Stefano Stabellini wrote: > On Fri, 26 Apr 2013, Julien Grall wrote: > > nr_lrs is only used in gic.c > > > > Signed-off-by: Julien Grall <julien.grall@linaro.org> > > Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Applied, thanks. Although we have a global gic state struct, is there some reason this isn't in there?
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 35376ef..bc8faf2 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -53,7 +53,7 @@ static irq_desc_t irq_desc[NR_IRQS]; static DEFINE_PER_CPU(irq_desc_t[NR_LOCAL_IRQS], local_irq_desc); static DEFINE_PER_CPU(uint64_t, lr_mask); -unsigned nr_lrs; +static unsigned nr_lrs; irq_desc_t *__irq_to_desc(int irq) {
nr_lrs is only used in gic.c Signed-off-by: Julien Grall <julien.grall@linaro.org> --- xen/arch/arm/gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)